Skip to content

Commit 0dd12a4

Browse files
sodabrewsodabrew
committed
Minors
1 parent 6dc7281 commit 0dd12a4

File tree

1 file changed

+31
-23
lines changed

1 file changed

+31
-23
lines changed

‎php_memcached.c

+31-23
Original file line numberDiff line numberDiff line change
@@ -1174,7 +1174,7 @@ static PHP_METHOD(Memcached, __construct)
11741174

11751175
zend_bool is_persistent = 0;
11761176

1177-
/* |S!f!S */
1177+
/* "|S!f!S" */
11781178
ZEND_PARSE_PARAMETERS_START(0, 3)
11791179
Z_PARAM_OPTIONAL
11801180
Z_PARAM_STR_EX(persistent_id, 1, 0)
@@ -1407,7 +1407,7 @@ void php_memc_get_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key)
14071407
MEMC_METHOD_INIT_VARS;
14081408

14091409
if (by_key) {
1410-
/* SS|f!l */
1410+
/* "SS|f!l" */
14111411
ZEND_PARSE_PARAMETERS_START(2, 4)
14121412
Z_PARAM_STR(server_key)
14131413
Z_PARAM_STR(key)
@@ -1416,7 +1416,7 @@ void php_memc_get_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key)
14161416
Z_PARAM_LONG(get_flags)
14171417
ZEND_PARSE_PARAMETERS_END();
14181418
} else {
1419-
/* S|f!l */
1419+
/* "S|f!l" */
14201420
ZEND_PARSE_PARAMETERS_START(1, 3)
14211421
Z_PARAM_STR(key)
14221422
Z_PARAM_OPTIONAL
@@ -1508,13 +1508,15 @@ static void php_memc_getMulti_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_ke
15081508
zend_bool retval, preserve_order;
15091509

15101510
if (by_key) {
1511+
/* "Sa|l" */
15111512
ZEND_PARSE_PARAMETERS_START(2, 3)
15121513
Z_PARAM_STR(server_key)
15131514
Z_PARAM_ARRAY(keys)
15141515
Z_PARAM_OPTIONAL
15151516
Z_PARAM_LONG(flags)
15161517
ZEND_PARSE_PARAMETERS_END();
15171518
} else {
1519+
/* "a|l" */
15181520
ZEND_PARSE_PARAMETERS_START(1, 2)
15191521
Z_PARAM_ARRAY(keys)
15201522
Z_PARAM_OPTIONAL
@@ -1649,16 +1651,18 @@ static void php_memc_getDelayed_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_
16491651

16501652

16511653
if (by_key) {
1654+
/* "Sa/|bf!" */
16521655
ZEND_PARSE_PARAMETERS_START(2, 4)
16531656
Z_PARAM_STR(server_key)
1654-
Z_PARAM_ARRAY(keys)
1657+
Z_PARAM_ARRAY_EX(keys, 0, 1)
16551658
Z_PARAM_OPTIONAL
16561659
Z_PARAM_BOOL(with_cas)
16571660
Z_PARAM_FUNC_EX(fci, fcc, 1, 0)
16581661
ZEND_PARSE_PARAMETERS_END();
16591662
} else {
1663+
/* "a/|bf!" */
16601664
ZEND_PARSE_PARAMETERS_START(1, 3)
1661-
Z_PARAM_ARRAY(keys)
1665+
Z_PARAM_ARRAY_EX(keys, 0, 1)
16621666
Z_PARAM_OPTIONAL
16631667
Z_PARAM_BOOL(with_cas)
16641668
Z_PARAM_FUNC_EX(fci, fcc, 1, 0)
@@ -1816,6 +1820,7 @@ static void php_memc_setMulti_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_ke
18161820
MEMC_METHOD_INIT_VARS;
18171821

18181822
if (by_key) {
1823+
/* "Sa|ll" */
18191824
ZEND_PARSE_PARAMETERS_START(2, 4)
18201825
Z_PARAM_STR(server_key)
18211826
Z_PARAM_ARRAY(entries)
@@ -1824,6 +1829,7 @@ static void php_memc_setMulti_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_ke
18241829
Z_PARAM_LONG(ignored)
18251830
ZEND_PARSE_PARAMETERS_END();
18261831
} else {
1832+
/* "a|ll" */
18271833
ZEND_PARSE_PARAMETERS_START(1, 3)
18281834
Z_PARAM_ARRAY(entries)
18291835
Z_PARAM_OPTIONAL
@@ -2040,7 +2046,7 @@ static void php_memc_cas_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key)
20402046
MEMC_METHOD_INIT_VARS;
20412047

20422048
if (by_key) {
2043-
/* zSSz|ll */
2049+
/* "zSSz|ll" */
20442050
ZEND_PARSE_PARAMETERS_START(4, 6)
20452051
Z_PARAM_ZVAL(zv_cas)
20462052
Z_PARAM_STR(server_key)
@@ -2051,7 +2057,7 @@ static void php_memc_cas_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key)
20512057
Z_PARAM_LONG(ignored)
20522058
ZEND_PARSE_PARAMETERS_END();
20532059
} else {
2054-
/* zSz|ll */
2060+
/* "zSz|ll" */
20552061
ZEND_PARSE_PARAMETERS_START(3, 5)
20562062
Z_PARAM_ZVAL(zv_cas)
20572063
Z_PARAM_STR(key)
@@ -2146,15 +2152,15 @@ static void php_memc_delete_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key)
21462152
MEMC_METHOD_INIT_VARS;
21472153

21482154
if (by_key) {
2149-
/* SS|l */
2155+
/* "SS|l" */
21502156
ZEND_PARSE_PARAMETERS_START(2, 3)
21512157
Z_PARAM_STR(server_key)
21522158
Z_PARAM_STR(key)
21532159
Z_PARAM_OPTIONAL
21542160
Z_PARAM_LONG(expiration)
21552161
ZEND_PARSE_PARAMETERS_END();
21562162
} else {
2157-
/* S|l */
2163+
/* "S|l" */
21582164
ZEND_PARSE_PARAMETERS_START(1, 2)
21592165
Z_PARAM_STR(key)
21602166
Z_PARAM_OPTIONAL
@@ -2194,15 +2200,15 @@ static void php_memc_deleteMulti_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by
21942200
MEMC_METHOD_INIT_VARS;
21952201

21962202
if (by_key) {
2197-
/* Sa/|l */
2203+
/* "Sa/|l" */
21982204
ZEND_PARSE_PARAMETERS_START(2, 3)
21992205
Z_PARAM_STR(server_key)
22002206
Z_PARAM_ARRAY_EX(entries, 0, 1)
22012207
Z_PARAM_OPTIONAL
22022208
Z_PARAM_LONG(expiration)
22032209
ZEND_PARSE_PARAMETERS_END();
22042210
} else {
2205-
/* a/|l */
2211+
/* "a/|l" */
22062212
ZEND_PARSE_PARAMETERS_START(1, 2)
22072213
Z_PARAM_ARRAY_EX(entries, 0, 1)
22082214
Z_PARAM_OPTIONAL
@@ -2255,6 +2261,7 @@ static void php_memc_incdec_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key,
22552261
MEMC_METHOD_INIT_VARS;
22562262

22572263
if (!by_key) {
2264+
/* "S|lll" */
22582265
ZEND_PARSE_PARAMETERS_START(1, 4)
22592266
Z_PARAM_STR(key)
22602267
Z_PARAM_OPTIONAL
@@ -2263,6 +2270,7 @@ static void php_memc_incdec_impl(INTERNAL_FUNCTION_PARAMETERS, zend_bool by_key,
22632270
Z_PARAM_LONG(expiry)
22642271
ZEND_PARSE_PARAMETERS_END();
22652272
} else {
2273+
/* "SS|lll" */
22662274
ZEND_PARSE_PARAMETERS_START(2, 5)
22672275
Z_PARAM_STR(server_key)
22682276
Z_PARAM_STR(key)
@@ -2381,7 +2389,7 @@ PHP_METHOD(Memcached, addServer)
23812389
memcached_return status;
23822390
MEMC_METHOD_INIT_VARS;
23832391

2384-
/* Sa/|l */
2392+
/* "Sa/|l" */
23852393
ZEND_PARSE_PARAMETERS_START(2, 3)
23862394
Z_PARAM_STR(host)
23872395
Z_PARAM_LONG(port)
@@ -2415,7 +2423,7 @@ PHP_METHOD(Memcached, addServers)
24152423
memcached_return status;
24162424
MEMC_METHOD_INIT_VARS;
24172425

2418-
/* a/ */
2426+
/* "a/" */
24192427
ZEND_PARSE_PARAMETERS_START(1, 1)
24202428
Z_PARAM_ARRAY_EX(servers, 0, 1)
24212429
ZEND_PARSE_PARAMETERS_END();
@@ -2520,7 +2528,7 @@ PHP_METHOD(Memcached, getServerByKey)
25202528
memcached_return error;
25212529
MEMC_METHOD_INIT_VARS;
25222530

2523-
/* S */
2531+
/* "S" */
25242532
ZEND_PARSE_PARAMETERS_START(1, 1)
25252533
Z_PARAM_STR(server_key)
25262534
ZEND_PARSE_PARAMETERS_END();
@@ -2741,7 +2749,7 @@ PHP_METHOD(Memcached, getStats)
27412749
zend_string *args_string = NULL;
27422750
MEMC_METHOD_INIT_VARS;
27432751

2744-
/* |S! */
2752+
/* "|S!" */
27452753
ZEND_PARSE_PARAMETERS_START(0, 1)
27462754
Z_PARAM_OPTIONAL
27472755
Z_PARAM_STR_EX(args_string, 1, 0)
@@ -2841,7 +2849,7 @@ static PHP_METHOD(Memcached, flush)
28412849
memcached_return status;
28422850
MEMC_METHOD_INIT_VARS;
28432851

2844-
/* |l */
2852+
/* "|l" */
28452853
ZEND_PARSE_PARAMETERS_START(0, 1)
28462854
Z_PARAM_OPTIONAL
28472855
Z_PARAM_LONG(delay)
@@ -2868,7 +2876,7 @@ static PHP_METHOD(Memcached, getOption)
28682876
memcached_behavior flag;
28692877
MEMC_METHOD_INIT_VARS;
28702878

2871-
/* l */
2879+
/* "l" */
28722880
ZEND_PARSE_PARAMETERS_START(1, 1)
28732881
Z_PARAM_LONG(option)
28742882
ZEND_PARSE_PARAMETERS_END();
@@ -3121,7 +3129,7 @@ PHP_METHOD(Memcached, setBucket)
31213129
memcached_return rc;
31223130
MEMC_METHOD_INIT_VARS;
31233131

3124-
/* aa!l */
3132+
/* "aa!l" */
31253133
ZEND_PARSE_PARAMETERS_START(3, 3)
31263134
Z_PARAM_ARRAY(zserver_map)
31273135
Z_PARAM_ARRAY_EX(zforward_map, 1, 0)
@@ -3187,7 +3195,7 @@ static PHP_METHOD(Memcached, setOptions)
31873195

31883196
MEMC_METHOD_INIT_VARS;
31893197

3190-
/* a */
3198+
/* "a" */
31913199
ZEND_PARSE_PARAMETERS_START(1, 1)
31923200
Z_PARAM_ARRAY(options)
31933201
ZEND_PARSE_PARAMETERS_END();
@@ -3218,7 +3226,7 @@ static PHP_METHOD(Memcached, setOption)
32183226
zval *value;
32193227
MEMC_METHOD_INIT_VARS;
32203228

3221-
/* lz/ */
3229+
/* "lz/" */
32223230
ZEND_PARSE_PARAMETERS_START(2, 2)
32233231
Z_PARAM_LONG(option)
32243232
Z_PARAM_ZVAL_EX(value, 0, 1)
@@ -3239,7 +3247,7 @@ static PHP_METHOD(Memcached, setSaslAuthData)
32393247
memcached_return status;
32403248
zend_string *user, *pass;
32413249

3242-
/* SS/ */
3250+
/* "SS/" */
32433251
ZEND_PARSE_PARAMETERS_START(2, 2)
32443252
Z_PARAM_STR(user)
32453253
Z_PARAM_STR(pass)
@@ -3725,7 +3733,7 @@ PHP_METHOD(MemcachedServer, run)
37253733
php_memc_server_t *intern;
37263734
intern = Z_MEMC_SERVER_P(getThis());
37273735

3728-
/* S */
3736+
/* "S" */
37293737
ZEND_PARSE_PARAMETERS_START(1, 1)
37303738
Z_PARAM_STR(address)
37313739
ZEND_PARSE_PARAMETERS_END();
@@ -3747,7 +3755,7 @@ PHP_METHOD(MemcachedServer, on)
37473755
zend_fcall_info_cache fci_cache;
37483756
zend_bool rc = 0;
37493757

3750-
/* lf! */
3758+
/* "lf!" */
37513759
ZEND_PARSE_PARAMETERS_START(2, 2)
37523760
Z_PARAM_LONG(event)
37533761
Z_PARAM_FUNC_EX(fci, fci_cache, 1, 0)

0 commit comments

Comments
 (0)