Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDEV projects not recognized when .ddev directory is in parent directory #113

Open
2 tasks done
cngJo opened this issue Oct 11, 2022 · 3 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@cngJo
Copy link

cngJo commented Oct 11, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Are you sure that this bug is related to this DDEV Integration Plugin?

  • I am sure

Enter your error report ID (If available)

No response

Describe the bug

This is kinda related to #104 but the other way around :-)

We have separate repositories for our ddev configuration, since we often manage multiple applications in one ddev project to allow easier communication nad not tie the local project configuration to the project source code.

The project is structured like this:

project-name-ddev
- .ddev
- web
- - part-1.dev
- - part-2.dev

We there open part-1.dev and part-2.dev in separate PhpStorm instances and work in them.

Unfortunally the DDEV Plugin does not recognize the .ddev direcory and therefore does not provide its functionality.

I'm not sure whats the best way to solve this, because it may be a performance issue to search in all parent directories until a .ddev directory is found.
Maybe one solution could be to allow the user to configure a path for the .ddev directory to use.

But to be honest, I'm not familiar with the inner workings of the plugin and IDEA plugins and don't know what the best solution would be, those are just my thoughts.
I'd be willing to help though where possible

Steps to reproduce

No response

Additional context

No response

@cngJo cngJo added the bug Something isn't working label Oct 11, 2022
@rfay
Copy link
Collaborator

rfay commented Oct 11, 2022

What do you open in PhpStorm, project-name-ddev ? Because if you do, I'd expect it to work, if not, please try it.

@nico-loeber
Copy link
Contributor

Hey @cngJo,

thanks for your feedback!
Sorry for the late reply, I didn't see any notification...

Indeed this is not yet supported by the plugin. The plugin will auto discover the .ddev configuration in the the root of the opend proejct.
Probably it would be possible to detect the configuration outside of the project scope, but this is... probably not that a good idea. The Plugin will also allow you to modify the configuration and I don't really like the idea to change files that are outside the scope of the currently opend project.

You mentioned #104 which is a similar feature request, so I will taske some time to think about a solution for this.

@cngJo
Copy link
Author

cngJo commented Oct 16, 2022

Hey @nico-loeber,

thanks for the reply :-)

I get the point that its propably a bad idea to work with directories outside the project scope.
I don't know how the plugin works internally but could configuring the ddev project name and use this as a base to interact with ddev instead of the .ddev directory?

I know its possible to provide this name to most of (or even all) ddev sub commands and get information form that.
But as I said I don't know if this is possible in the scope of this plugin, just wanted it to "throw it in the pod of ideas".

If possible this would propably also solve #104.

I also tried the workaround mentioned by @rfay.
That works for now and I'd propably use it for now. I'd want to help implementing a "proper" solution for this where this is not needed.
(Those part-x.dev are full blown projects like shopware and TYPO3 installations - it would be great to prevent indexing them when not needed)

Thank you and let me know if you need something from me this regarding this topic ;)

@nico-loeber nico-loeber added enhancement New feature or request and removed bug Something isn't working labels Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants