add return method value types

Author: guillaume-sainthillier

src/bref/src/ConsoleApplicationHandler.php

@@ -23,7 +23,7 @@ public function __construct(Application $application)
         $this->application->setAutoExit(false);
     }
 
-    public function handle($event, Context $context)
+    public function handle($event, Context $context): array
     {
         $args = \Clue\Arguments\split((string) $event);
         array_unshift($args, 'command');

src/bref/src/Runtime.php

@@ -46,7 +46,7 @@ public function getRunner(?object $application): RunnerInterface
         }
     }
 
-    private function tryToFindRunner(?object $application)
+    private function tryToFindRunner(?object $application): RunnerInterface
     {
         if ($application instanceof ContainerInterface) {
             $handler = explode(':', $_SERVER['_HANDLER']);

src/bref/tests/Lambda/LambdaClientTest.php

@@ -32,12 +32,12 @@ protected function tearDown(): void
         ob_end_clean();
     }
 
-    public function test basic behavior()
+    public function test basic behavior(): void
     {
         $this->givenAnEvent(['Hello' => 'world!']);
 
         $output = $this->lambda->processNextEvent(new class implements Handler {
-            public function handle($event, Context $context)
+            public function handle($event, Context $context): array
             {
                 return ['hello' => 'world'];
             }
@@ -47,12 +47,12 @@ public function handle($event, Context $context)
         $this->assertInvocationResult(['hello' => 'world']);
     }
 
-    public function test handler receives context()
+    public function test handler receives context(): void
     {
         $this->givenAnEvent(['Hello' => 'world!']);
 
         $this->lambda->processNextEvent(new class implements Handler {
-            public function handle($event, Context $context)
+            public function handle($event, Context $context): array
             {
                 return ['hello' => 'world', 'received-function-arn' => $context->getInvokedFunctionArn()];
             }
@@ -64,7 +64,7 @@ public function handle($event, Context $context)
         ]);
     }
 
-    public function test exceptions in the handler result in an invocation error()
+    public function test exceptions in the handler result in an invocation error(): void
     {
         $this->givenAnEvent(['Hello' => 'world!']);
 
@@ -80,7 +80,7 @@ public function handle($event, Context $context)
         $this->assertErrorInLogs('RuntimeException', 'This is an exception');
     }
 
-    public function test nested exceptions in the handler result in an invocation error()
+    public function test nested exceptions in the handler result in an invocation error(): void
     {
         $this->givenAnEvent(['Hello' => 'world!']);
 
@@ -99,7 +99,7 @@ public function handle($event, Context $context)
         ]);
     }
 
-    public function test an error is thrown if the runtime API returns a wrong response()
+    public function test an error is thrown if the runtime API returns a wrong response(): void
     {
         $this->expectExceptionMessage('Failed to fetch next Lambda invocation: The requested URL returned error: 404');
         Server::enqueue([
@@ -119,7 +119,7 @@ public function handle($event, Context $context)
         });
     }
 
-    public function test an error is thrown if the invocation id is missing()
+    public function test an error is thrown if the invocation id is missing(): void
     {
         $this->expectExceptionMessage('Failed to determine the Lambda invocation ID');
         Server::enqueue([
@@ -137,7 +137,7 @@ public function handle($event, Context $context)
         });
     }
 
-    public function test an error is thrown if the invocation body is empty()
+    public function test an error is thrown if the invocation body is empty(): void
     {
         $this->expectExceptionMessage('Empty Lambda runtime API response');
         Server::enqueue([
@@ -156,7 +156,7 @@ public function handle($event, Context $context)
         });
     }
 
-    public function test a wrong response from the runtime API turns the invocation into an error()
+    public function test a wrong response from the runtime API turns the invocation into an error(): void
     {
         Server::enqueue([
             new Response( // lambda event
@@ -194,12 +194,12 @@ public function handle($event, Context $context)
         $this->assertErrorInLogs('Exception', 'Error while calling the Lambda runtime API: The requested URL returned error: 400');
     }
 
-    public function test function results that cannot be encoded are reported as invocation errors()
+    public function test function results that cannot be encoded are reported as invocation errors(): void
     {
         $this->givenAnEvent(['hello' => 'world!']);
 
         $this->lambda->processNextEvent(new class implements Handler {
-            public function handle($event, Context $context)
+            public function handle($event, Context $context): string
             {
                 return "\xB1\x31";
             }
@@ -214,7 +214,7 @@ public function handle($event, Context $context)
         $this->assertErrorInLogs('Exception', $message);
     }
 
-    public function test generic event handler()
+    public function test generic event handler(): void
     {
         $handler = new class implements Handler {
             public function handle($event, Context $context)
@@ -245,7 +245,7 @@ private function givenAnEvent($event): void
         ]);
     }
 
-    private function assertInvocationResult($result)
+    private function assertInvocationResult($result): void
     {
         $requests = Server::received();
         $this->assertCount(2, $requests);
@@ -258,7 +258,7 @@ private function assertInvocationResult($result)
         $this->assertEquals($result, json_decode($eventResponse->getBody()->__toString(), true));
     }
 
-    private function assertInvocationErrorResult(string $errorClass, string $errorMessage)
+    private function assertInvocationErrorResult(string $errorClass, string $errorMessage): void
     {
         $requests = Server::received();
         $this->assertCount(2, $requests);
@@ -305,7 +305,7 @@ private function assertErrorInLogs(string $errorClass, string $errorMessage): vo
         $this->assertIsArray($invocationResult['stack']);
     }
 
-    private function assertPreviousErrorsInLogs(array $previousErrors)
+    private function assertPreviousErrorsInLogs(array $previousErrors): void
     {
         // Decode the logs from stdout
         $stdout = $this->getActualOutput();

src/bref/tests/SymfonyRequestBridgeTest.php

@@ -11,7 +11,7 @@
 
 class SymfonyRequestBridgeTest extends TestCase
 {
-    public function testClientIpFromForwardedFor()
+    public function testClientIpFromForwardedFor(): void
     {
         $request = SymfonyRequestBridge::convertRequest(new HttpRequestEvent([
             'requestContext' => ['http' => ['method' => 'GET']],
@@ -23,7 +23,7 @@ public function testClientIpFromForwardedFor()
     /**
      * Raw content should only exist when there is no multipart content.
      */
-    public function testRawContent()
+    public function testRawContent(): void
     {
         // No content type
         $request = SymfonyRequestBridge::convertRequest(new HttpRequestEvent([
@@ -67,7 +67,7 @@ public function testRawContent()
         $this->assertSame('', $request->getContent());
     }
 
-    public function testUploadedFile()
+    public function testUploadedFile(): void
     {
         $request = SymfonyRequestBridge::convertRequest(new HttpRequestEvent([
             'requestContext' => ['http' => ['method' => 'POST']],
@@ -107,7 +107,7 @@ public function testUploadedFile()
         $this->assertSame('bar', $post['foo']);
     }
 
-    public function testEmptyUploadedFile()
+    public function testEmptyUploadedFile(): void
     {
         $request = SymfonyRequestBridge::convertRequest(new HttpRequestEvent([
             'requestContext' => ['http' => ['method' => 'POST']],
@@ -136,7 +136,7 @@ public function testEmptyUploadedFile()
         $this->assertSame('bar', $post['foo']);
     }
 
-    public function testLambdaContext()
+    public function testLambdaContext(): void
     {
         $requestContext = ['http' => ['method' => 'GET']];
         $request = SymfonyRequestBridge::convertRequest(new HttpRequestEvent([
@@ -149,7 +149,7 @@ public function testLambdaContext()
         $this->assertSame(json_encode($requestContext), $request->server->get('LAMBDA_REQUEST_CONTEXT'));
     }
 
-    private function getContext()
+    private function getContext(): Context
     {
         // this is set in LaravelHttpHandler and SymfonyHttpHandler to allow overwrite of this value
         Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_FOR | Request::HEADER_X_FORWARDED_HOST | Request::HEADER_X_FORWARDED_PORT | Request::HEADER_X_FORWARDED_PROTO);

src/google-cloud/google/CloudEvent.php

@@ -81,7 +81,7 @@ public function getData()
         return $this->data;
     }
 
-    public static function fromArray(array $arr)
+    public static function fromArray(array $arr): static
     {
         $args = [];
         $argKeys = [

src/google-cloud/google/Context.php

@@ -54,7 +54,7 @@ public function getResourceName(): ?string
         return $this->resource['name'] ?? null;
     }
 
-    public static function fromArray(array $arr)
+    public static function fromArray(array $arr): static
     {
         // When "resource" is defined in the root (instead of in "context") it
         // is a string representing the resource name

src/google-cloud/src/Runtime.php

@@ -90,7 +90,7 @@ protected function createCloudEvent(): ?CloudEvent
         }
     }
 
-    protected function sendHttpResponseAndExit(int $status, string $body, array $headers)
+    protected function sendHttpResponseAndExit(int $status, string $body, array $headers): void
     {
         error_log($body);
         header('HTTP/1.1 '.$status);

src/google-cloud/tests/google/CloudEventTest.php

@@ -26,7 +26,7 @@
  */
 class CloudEventTest extends TestCase
 {
-    public function testJsonSerialize()
+    public function testJsonSerialize(): void
     {
         $event = new CloudEvent(
             '1413058901901494',

src/google-cloud/tests/google/ContextTest.php

@@ -26,7 +26,7 @@
  */
 class ContextTest extends TestCase
 {
-    public function testFromArray()
+    public function testFromArray(): void
     {
         $context = Context::fromArray([
             'eventId' => 'abc',
@@ -45,7 +45,7 @@ public function testFromArray()
         $this->assertEquals('mno', $context->getService());
     }
 
-    public function testFromEmptyArray()
+    public function testFromEmptyArray(): void
     {
         $context = Context::fromArray([]);
         $this->assertEquals(null, $context->getEventId());

src/google-cloud/tests/google/LegacyEventMapperTest.php

@@ -26,7 +26,7 @@
  */
 class LegacyEventMapperTest extends TestCase
 {
-    public function testWithContextProperty()
+    public function testWithContextProperty(): void
     {
         $mapper = new LegacyEventMapper();
         $jsonData = [
@@ -61,7 +61,7 @@ public function testWithContextProperty()
         $this->assertEquals(['message' => 'foo'], $cloudevent->getData());
     }
 
-    public function testWithoutContextProperty()
+    public function testWithoutContextProperty(): void
     {
         $mapper = new LegacyEventMapper();
         $jsonData = [
@@ -95,7 +95,7 @@ public function testWithoutContextProperty()
         $this->assertEquals(['message' => 'foo'], $cloudevent->getData());
     }
 
-    public function testResourceAsString()
+    public function testResourceAsString(): void
     {
         $mapper = new LegacyEventMapper();
         $jsonData = [
@@ -126,7 +126,7 @@ public function testResourceAsString()
         $this->assertEquals(['message' => 'foo'], $cloudevent->getData());
     }
 
-    public function testCloudStorage()
+    public function testCloudStorage(): void
     {
         $mapper = new LegacyEventMapper();
         $jsonData = [
@@ -163,7 +163,7 @@ public function testCloudStorage()
         $this->assertEquals('foo', $cloudevent->getData());
     }
 
-    public function testFirebaseAuth()
+    public function testFirebaseAuth(): void
     {
         $mapper = new LegacyEventMapper();
         $jsonData = [