Merge pull request #221 from php-school/composer-install-for-test-solutions

Install composer deps for test solutions

Author: AydinHassan

src/Listener/PrepareSolutionListener.php

@@ -19,7 +19,7 @@ class PrepareSolutionListener
      *
      * @var array<string>
      */
-    private $composerLocations = [
+    private static $composerLocations = [
         'composer',
         'composer.phar',
         '/usr/local/bin/composer',
@@ -45,7 +45,7 @@ public function __invoke(ExerciseRunnerEvent $event): void
 
             if (!file_exists(sprintf('%s/vendor', $solution->getBaseDirectory()))) {
                 $process = new Process(
-                    [$this->locateComposer(), 'install', '--no-interaction'],
+                    [self::locateComposer(), 'install', '--no-interaction'],
                     $solution->getBaseDirectory()
                 );
                 $process->run();
@@ -56,9 +56,9 @@ public function __invoke(ExerciseRunnerEvent $event): void
     /**
      * @return string
      */
-    private function locateComposer(): string
+    public static function locateComposer(): string
     {
-        foreach ($this->composerLocations as $location) {
+        foreach (self::$composerLocations as $location) {
             if (file_exists($location) && is_executable($location)) {
                 return $location;
             }

src/TestUtils/WorkshopExerciseTest.php

@@ -9,8 +9,11 @@
 use PhpSchool\PhpWorkshop\Exercise\AbstractExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
+use PhpSchool\PhpWorkshop\Exercise\ProvidesSolution;
+use PhpSchool\PhpWorkshop\ExerciseCheck\ComposerExerciseCheck;
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
 use PhpSchool\PhpWorkshop\ExerciseRepository;
+use PhpSchool\PhpWorkshop\Listener\PrepareSolutionListener;
 use PhpSchool\PhpWorkshop\Result\Cgi\CgiResult;
 use PhpSchool\PhpWorkshop\Result\Cli\CliResult;
 use PhpSchool\PhpWorkshop\Result\Failure;
@@ -23,6 +26,7 @@
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;
 use PhpSchool\PhpWorkshop\Input\Input;
+use Symfony\Component\Process\Process;
 
 abstract class WorkshopExerciseTest extends TestCase
 {
@@ -81,6 +85,10 @@ public function runExercise(string $submissionFile): void
             );
         }
 
+        if ($exercise instanceof ComposerExerciseCheck) {
+            $this->installDeps($exercise, dirname($submissionFileAbsolute));
+        }
+
         $input = new Input($this->container->get('appName'), [
             'program' => $submissionFileAbsolute
         ]);
@@ -89,6 +97,21 @@ public function runExercise(string $submissionFile): void
             ->verify($exercise, $input);
     }
 
+    /**
+     * @param ExerciseInterface&ProvidesSolution $exercise
+     * @param string $directory
+     */
+    private function installDeps(ExerciseInterface $exercise, string $directory): void
+    {
+        if (file_exists("$directory/composer.json") && !file_exists("$directory/vendor")) {
+            $process = new Process(
+                [PrepareSolutionListener::locateComposer(), 'install', '--no-interaction'],
+                $directory
+            );
+            $process->run();
+        }
+    }
+
     public function assertVerifyWasSuccessful(): void
     {
         $failures = (new Collection($this->results->getIterator()->getArrayCopy()))

test/Listener/PrepareSolutionListenerTest.php

@@ -44,6 +44,9 @@ public function setUp(): void
         touch($this->file);
     }
 
+    /**
+     * @runInSeparateProcess
+     */
     public function testIfSolutionRequiresComposerButComposerCannotBeLocatedExceptionIsThrown(): void
     {
         $refProp = new ReflectionProperty(PrepareSolutionListener::class, 'composerLocations');