More tests + fixes

Author: AydinHassan

src/Exercise/ASafeSpaceForNulls.php

@@ -38,6 +38,9 @@ class ASafeSpaceForNulls extends AbstractExercise implements
     FileComparisonExerciseCheck,
     SelfCheck
 {
+
+    private ?Patch $patch = null;
+
     public function __construct(private Parser $parser, private FakerGenerator $faker)
     {
     }
@@ -69,6 +72,11 @@ public function configure(ExerciseDispatcher $dispatcher): void
 
     public function getPatch(): Patch
     {
+        if ($this->patch) {
+            return $this->patch;
+        }
+
+
         $factory = new BuilderFactory();
 
         $statements = [];
@@ -158,7 +166,7 @@ public function getPatch(): Patch
             }
         }
 
-        return (new Patch())
+        return $this->patch = (new Patch())
             ->withTransformer(function (array $originalStatements) use ($statements) {
                 return array_merge($statements, $originalStatements);
             });

test/Exercise/ASafeSpaceForNullsTest.php

@@ -103,18 +103,20 @@ public function testFailureWhenCsvNotCorrect(): void
 
         $this->assertVerifyWasNotSuccessful();
 
-        $this->assertResultsHasFailure(
-            Failure::class,
-            'File: "users.csv" does not exist'
+        $this->assertResultsHasFailureAndMatches(
+            FileComparisonFailure::class,
+            function (FileComparisonFailure $failure) {
+                self::assertEquals('users.csv', $failure->getFileName());
+
+                return true;
+            }
         );
+    }
+
+    public function testWithCorrectSolution(): void
+    {
+        $this->runExercise('correct-solution.php');
 
-//        $this->assertResultsHasFailureAndMatches(
-//            FileComparisonFailure::class,
-//            function (FileComparisonFailure $failure) {
-//                self::assertEquals('users.csv', $failure->getFileName());
-//
-//                return true;
-//            }
-//        );
+        $this->assertVerifyWasSuccessful();
     }
 }

test/solutions/a-safe-space-for-nulls/correct-solution.php

@@ -0,0 +1,6 @@
+<?php
+
+$fp = fopen('users.csv', 'w+');
+fputcsv($fp, ['First Name', 'Last Name', 'Age', 'House num', 'Addr 1', 'Addr 2']);
+fputcsv($fp, [$user->firstName, $user->lastName, $user?->age, $user?->address?->number, $user?->address?->addressLine1, $user?->address?->addressLine2]);
+fclose($fp);