FIx memory leak in phar_parse_zipfile() error handling

ndossche · ndossche · commit 3711a57538af · 2025-10-11T12:56:10.000+02:00
diff --git a/ext/phar/zip.c b/ext/phar/zip.c
@@ -697,7 +697,8 @@ int phar_parse_zipfile(php_stream *fp, char *fname, size_t fname_len, char *alia
 					}
 				}
 
-				if (!entry.uncompressed_filesize || !actual_alias) {
+				if (!entry.uncompressed_filesize) {
+					efree(actual_alias);
 					pefree(entry.filename, entry.is_persistent);
 					PHAR_ZIP_FAIL("unable to read in alias, truncated");
 				}

Original file line number	Diff line number	Diff line change
`@@ -697,7 +697,8 @@ int phar_parse_zipfile(php_stream fp, char fname, size_t fname_len, char *alia`
`697`	`697`	`}`
`698`	`698`	`}`
`699`	`699`
`700`		`- if (!entry.uncompressed_filesize \|\| !actual_alias) {`
	`700`	`+ if (!entry.uncompressed_filesize) {`
	`701`	`+ efree(actual_alias);`
`701`	`702`	`pefree(entry.filename, entry.is_persistent);`
`702`	`703`	`PHAR_ZIP_FAIL("unable to read in alias, truncated");`
`703`	`704`	`}`