Skip to content

Commit 685bd9d

Browse files
committed
Merge branch 'PHP-8.2' into PHP-8.3
* PHP-8.2: Suppress libxml deprecations
2 parents c343ede + 26b9395 commit 685bd9d

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

ext/dom/document.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,12 +1541,16 @@ PHP_METHOD(DOMDocument, save)
15411541
libxml_doc_props const* doc_props = dom_get_doc_props_read_only(intern->document);
15421542
format = doc_props->formatoutput;
15431543
if (options & LIBXML_SAVE_NOEMPTYTAG) {
1544+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
15441545
saveempty = xmlSaveNoEmptyTags;
15451546
xmlSaveNoEmptyTags = 1;
1547+
ZEND_DIAGNOSTIC_IGNORED_END
15461548
}
15471549
bytes = xmlSaveFormatFileEnc(file, docp, NULL, format);
15481550
if (options & LIBXML_SAVE_NOEMPTYTAG) {
1551+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
15491552
xmlSaveNoEmptyTags = saveempty;
1553+
ZEND_DIAGNOSTIC_IGNORED_END
15501554
}
15511555
if (bytes == -1) {
15521556
RETURN_FALSE;
@@ -1593,10 +1597,14 @@ PHP_METHOD(DOMDocument, saveXML)
15931597
RETURN_FALSE;
15941598
}
15951599
/* Save libxml2 global, override its vaule, and restore after saving. */
1600+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
15961601
old_xml_save_no_empty_tags = xmlSaveNoEmptyTags;
15971602
xmlSaveNoEmptyTags = (options & LIBXML_SAVE_NOEMPTYTAG) ? 1 : 0;
1603+
ZEND_DIAGNOSTIC_IGNORED_END
15981604
xmlNodeDump(buf, docp, node, 0, format);
1605+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
15991606
xmlSaveNoEmptyTags = old_xml_save_no_empty_tags;
1607+
ZEND_DIAGNOSTIC_IGNORED_END
16001608
} else {
16011609
buf = xmlBufferCreate();
16021610
if (!buf) {
@@ -1612,11 +1620,15 @@ PHP_METHOD(DOMDocument, saveXML)
16121620
converted_options |= XML_SAVE_FORMAT;
16131621
}
16141622
/* Save libxml2 global, override its vaule, and restore after saving. */
1623+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
16151624
old_xml_save_no_empty_tags = xmlSaveNoEmptyTags;
16161625
xmlSaveNoEmptyTags = (options & LIBXML_SAVE_NOEMPTYTAG) ? 1 : 0;
1626+
ZEND_DIAGNOSTIC_IGNORED_END
16171627
/* Encoding is handled from the encoding property set on the document */
16181628
xmlSaveCtxtPtr ctxt = xmlSaveToBuffer(buf, (const char *) docp->encoding, converted_options);
1629+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
16191630
xmlSaveNoEmptyTags = old_xml_save_no_empty_tags;
1631+
ZEND_DIAGNOSTIC_IGNORED_END
16201632
if (UNEXPECTED(!ctxt)) {
16211633
xmlBufferFree(buf);
16221634
php_error_docref(NULL, E_WARNING, "Could not create save context");

ext/libxml/libxml.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -827,9 +827,12 @@ static xmlParserInputPtr _php_libxml_external_entity_loader(const char *URL,
827827
} else {
828828
/* make stream not being closed when the zval is freed */
829829
GC_ADDREF(stream->res);
830+
831+
ZEND_DIAGNOSTIC_IGNORED_START("-Wdeprecated-declarations")
830832
pib->context = stream;
831833
pib->readcallback = php_libxml_streams_IO_read;
832834
pib->closecallback = php_libxml_streams_IO_close;
835+
ZEND_DIAGNOSTIC_IGNORED_END
833836

834837
ret = xmlNewIOInputStream(context, pib, enc);
835838
if (ret == NULL) {

0 commit comments

Comments
 (0)