Add error for libmysqlclient

A new test case was added to check for the exception with libmysqlclient

Author: kamil-tekiela

ext/mysqli/mysqli_api.c

@@ -822,8 +822,8 @@ PHP_FUNCTION(mysqli_stmt_execute)
 	MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID);
 
 	// bind-in-execute
-#if defined(MYSQLI_USE_MYSQLND)
 	if (input_params) {
+#if defined(MYSQLI_USE_MYSQLND)
 		zval *tmp;
 		unsigned int index;
 		unsigned int hash_num_elements;
@@ -854,8 +854,11 @@ PHP_FUNCTION(mysqli_stmt_execute)
 			MYSQLI_REPORT_STMT_ERROR(stmt->stmt);
 			RETVAL_FALSE;
 		}
-	}
+#else
+		zend_argument_count_error("Binding parameters in execute is not supported with libmysqlclient");
+		RETURN_THROWS();
 #endif
+	}
 
 #ifndef MYSQLI_USE_MYSQLND
 	if (stmt->param.var_cnt) {

ext/mysqli/tests/mysqli_stmt_execute_bind.phpt

@@ -10,6 +10,9 @@ if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) {
 if (mysqli_get_server_version($link) <= 40100) {
     die(sprintf('skip Needs MySQL 4.1+, found version %d.', mysqli_get_server_version($link)));
 }
+if (!stristr(mysqli_get_client_info(), 'mysqlnd')) {
+    die("skip: only available in mysqlnd");
+}
 ?>
 --FILE--
 <?php

ext/mysqli/tests/mysqli_stmt_execute_bind_libmysql.phpt

@@ -0,0 +1,52 @@
+--TEST--
+mysqli_stmt_execute() - bind in execute
+--SKIPIF--
+<?php
+require_once('skipif.inc');
+require_once('skipifconnectfailure.inc');
+if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) {
+    die(sprintf('skip Cannot connect to MySQL, [%d] %s.', mysqli_connect_errno(), mysqli_connect_error()));
+}
+if (mysqli_get_server_version($link) <= 40100) {
+    die(sprintf('skip Needs MySQL 4.1+, found version %d.', mysqli_get_server_version($link)));
+}
+if (stristr(mysqli_get_client_info(), 'mysqlnd')) {
+    die("skip: only applicable for libmysqlclient");
+}
+?>
+--FILE--
+<?php
+    require_once("connect.inc");
+
+    require('table.inc');
+
+    mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
+
+    // first, control case
+    $id = 1;
+    $abc = 'abc';
+    $stmt = $link->prepare('SELECT label, ? AS anon, ? AS num FROM test WHERE id=?');
+    $stmt->bind_param('sss', ...[&$abc, 42, $id]);
+    $stmt->execute();
+    assert($stmt->get_result()->fetch_assoc() === ['label'=>'a', 'anon'=>'abc', 'num' => '42']);
+    $stmt = null;
+
+    // 1. same as the control case, but skipping the middle-man (bind_param)
+    $stmt = $link->prepare('SELECT label, ? AS anon, ? AS num FROM test WHERE id=?');
+    try {
+        $stmt->execute([&$abc, 42, $id]);
+    } catch (ArgumentCountError $e) {
+        echo '[001] '.$e->getMessage()."\n";
+    }
+    $stmt = null;
+
+    mysqli_close($link);
+    print "done!";
+?>
+--CLEAN--
+<?php
+    require_once("clean_table.inc");
+?>
+--EXPECT--
+[001] Binding parameters in execute is not supported with libmysqlclient
+done!