Make $params non-nullable

Author: kamil-tekiela

ext/mysqli/mysqli.stub.php

@@ -507,7 +507,7 @@ public function data_seek(int $offset) {}
      * @return bool
      * @alias mysqli_stmt_execute
      */
-    public function execute(?array $params = null) {}
+    public function execute(array $params = []) {}
 
     /**
      * @return bool|null
@@ -644,10 +644,10 @@ function mysqli_error(mysqli $mysql): string {}
 
 function mysqli_error_list(mysqli $mysql): array {}
 
-function mysqli_stmt_execute(mysqli_stmt $statement, ?array $params = null): bool {}
+function mysqli_stmt_execute(mysqli_stmt $statement, array $params = []): bool {}
 
 /** @alias mysqli_stmt_execute */
-function mysqli_execute(mysqli_stmt $statement, ?array $params = null): bool {}
+function mysqli_execute(mysqli_stmt $statement, array $params = []): bool {}
 
 function mysqli_fetch_field(mysqli_result $result): object|false {}
 

ext/mysqli/mysqli_api.c

@@ -816,7 +816,7 @@ PHP_FUNCTION(mysqli_stmt_execute)
 	unsigned int	i;
 #endif
 
-	if (zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(), "O|h!", &mysql_stmt, mysqli_stmt_class_entry, &input_params) == FAILURE) {
+	if (zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(), "O|h", &mysql_stmt, mysqli_stmt_class_entry, &input_params) == FAILURE) {
 		RETURN_THROWS();
 	}
 	MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID);

ext/mysqli/mysqli_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 3f3d19da5a2b7c8edc6dba0fde6215b93d10bb32 */
+ * Stub hash: 35c309740ea0ee7328ec5dfdbbad057097ca24e7 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_mysqli_affected_rows, 0, 1, MAY_BE_LONG|MAY_BE_STRING)
 	ZEND_ARG_OBJ_INFO(0, mysql, mysqli, 0)
@@ -71,7 +71,7 @@ ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_mysqli_stmt_execute, 0, 1, _IS_BOOL, 0)
 	ZEND_ARG_OBJ_INFO(0, statement, mysqli_stmt, 0)
-	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, params, IS_ARRAY, 1, "null")
+	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, params, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 #define arginfo_mysqli_execute arginfo_mysqli_stmt_execute
@@ -644,7 +644,7 @@ ZEND_END_ARG_INFO()
 #define arginfo_class_mysqli_stmt_data_seek arginfo_class_mysqli_result_data_seek
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_mysqli_stmt_execute, 0, 0, 0)
-	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, params, IS_ARRAY, 1, "null")
+	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, params, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 #define arginfo_class_mysqli_stmt_fetch arginfo_class_mysqli_character_set_name

ext/mysqli/tests/mysqli_stmt_execute_bind.phpt

@@ -147,8 +147,8 @@ if (!stristr(mysqli_get_client_info(), 'mysqlnd')) {
 [002] mysqli_stmt::execute(): Argument #1 ($params) must consist of exactly 3 elements, 4 present
 [003] mysqli_stmt::execute(): Argument #1 ($params) must consist of exactly 3 elements, 0 present
 [004] No data supplied for parameters in prepared statement
-[005] mysqli_stmt::execute(): Argument #1 ($params) must be of type ?array, int given
-[006] mysqli_stmt::execute(): Argument #1 ($params) must be of type ?array, stdClass given
+[005] mysqli_stmt::execute(): Argument #1 ($params) must be of type array, int given
+[006] mysqli_stmt::execute(): Argument #1 ($params) must be of type array, stdClass given
 [007] mysqli_stmt::execute(): Argument #1 ($params) must consist of exactly 3 elements, 0 present
 [008] mysqli_stmt::execute(): Argument #1 ($params) must be a list array
 done!