Address review comments about missing empty FCC assignment

Girgias · Girgias · commit 9ad63b158c33 · 2024-04-30T22:13:42.000+01:00
diff --git a/ext/curl/multi.c b/ext/curl/multi.c
@@ -446,6 +446,7 @@ static bool _php_curl_multi_setopt(php_curlm *mh, zend_long option, zval *zvalue
 			/* See php_curl_set_callable_handler */
 			if (ZEND_FCC_INITIALIZED(mh->handlers.server_push)) {
 				zend_fcc_dtor(&mh->handlers.server_push);
+				mh->handlers.server_push = empty_fcall_info_cache;
 			}
 
 			char *error_str = NULL;
@@ -543,6 +544,7 @@ static void curl_multi_free_obj(zend_object *object)
 
 	if (ZEND_FCC_INITIALIZED(mh->handlers.server_push)) {
 		zend_fcc_dtor(&mh->handlers.server_push);
+		mh->handlers.server_push = empty_fcall_info_cache;
 	}
 
 	zend_object_std_dtor(&mh->std);

Original file line number	Diff line number	Diff line change
`@@ -446,6 +446,7 @@ static bool _php_curl_multi_setopt(php_curlm mh, zend_long option, zval zvalue`
`446`	`446`	`/* See php_curl_set_callable_handler */`
`447`	`447`	`if (ZEND_FCC_INITIALIZED(mh->handlers.server_push)) {`
`448`	`448`	`zend_fcc_dtor(&mh->handlers.server_push);`
	`449`	`+ mh->handlers.server_push = empty_fcall_info_cache;`
`449`	`450`	`}`
`450`	`451`
`451`	`452`	`char *error_str = NULL;`
`@@ -543,6 +544,7 @@ static void curl_multi_free_obj(zend_object *object)`
`543`	`544`
`544`	`545`	`if (ZEND_FCC_INITIALIZED(mh->handlers.server_push)) {`
`545`	`546`	`zend_fcc_dtor(&mh->handlers.server_push);`
	`547`	`+ mh->handlers.server_push = empty_fcall_info_cache;`
`546`	`548`	`}`
`547`	`549`
`548`	`550`	`zend_object_std_dtor(&mh->std);`