Skip to content

Commit eb9955d

Browse files
committed
Address review comments
1 parent e69e7fa commit eb9955d

File tree

88 files changed

+142
-204
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+142
-204
lines changed

ext/pdo/tests/bug_34630.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var_dump($db->query("SELECT * from test34630")->fetchAll(PDO::FETCH_ASSOC));
5050
<?php
5151
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
5252
$db = PDOTest::factory();
53-
$db->exec("DROP TABLE test34630");
53+
PDOTest::dropTableIfExists($db, "test34630");
5454
?>
5555
--EXPECT--
5656
array(1) {

ext/pdo/tests/bug_35671.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ var_dump($db->query("SELECT * from test35671")->fetchAll(PDO::FETCH_ASSOC));
3636
<?php
3737
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3838
$db = PDOTest::factory();
39-
$db->exec("DROP TABLE test35671");
39+
PDOTest::dropTableIfExists($db, "test35671");
4040
?>
4141
--EXPECT--
4242
array(1) {

ext/pdo/tests/bug_36428.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var_dump($res->fetchAll(PDO::FETCH_CLASS|PDO::FETCH_PROPS_LATE, 'SimpleXMLElemen
2626
<?php
2727
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
2828
$db = PDOTest::factory();
29-
$db->exec("DROP TABLE test36428");
29+
PDOTest::dropTableIfExists($db, "test36428");
3030
?>
3131
--EXPECTF--
3232
array(1) {

ext/pdo/tests/bug_36798.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ $db = PDOTest::factory();
2929
$db->exec("CREATE TABLE test36798 (id INTEGER)");
3030
$db->exec("INSERT INTO test36798 (id) VALUES (1)");
3131

32-
$stmt = $db->prepare("SELECT '' as test FROM test36798 WHERE id = :id");
32+
$stmt = $db->prepare("SELECT 'Ã' as test FROM test36798 WHERE id = :id");
3333
$stmt->execute(array(":id" => 1));
3434

3535
$row = $stmt->fetch(PDO::FETCH_NUM);
@@ -40,7 +40,7 @@ var_dump( $row );
4040
<?php
4141
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
4242
$db = PDOTest::factory();
43-
$db->exec("DROP TABLE test36798");
43+
PDOTest::dropTableIfExists($db, "test36798");
4444
?>
4545
--EXPECT--
4646
array(1) {

ext/pdo/tests/bug_38253.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var_dump($stmt->fetchAll());
3333
<?php
3434
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3535
$db = PDOTest::factory();
36-
$db->exec("DROP TABLE test38253");
36+
PDOTest::dropTableIfExists($db, "test38253");
3737
?>
3838
--EXPECTF--
3939
Warning: PDOStatement::fetchAll(): SQLSTATE[HY000]: General error: No fetch class specified in %s on line %d

ext/pdo/tests/bug_38394.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var_dump($db->query("SELECT * FROM test38394")->fetchAll(PDO::FETCH_ASSOC));
3131
<?php
3232
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3333
$db = PDOTest::factory();
34-
$db->exec("DROP TABLE test38394");
34+
PDOTest::dropTableIfExists($db, "test38394");
3535
?>
3636
--EXPECT--
3737
array(2) {

ext/pdo/tests/bug_39398.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var_dump($db->query("SELECT * FROM test39398")->fetchAll(PDO::FETCH_ASSOC));
2828
<?php
2929
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3030
$db = PDOTest::factory();
31-
$db->exec("DROP TABLE test39398");
31+
PDOTest::dropTableIfExists($db, "test39398");
3232
?>
3333
--EXPECT--
3434
array(1) {

ext/pdo/tests/bug_39656.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ echo "Done\n";
3838
<?php
3939
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
4040
$db = PDOTest::factory();
41-
$db->exec("DROP TABLE test39656");
41+
PDOTest::dropTableIfExists($db, "test39656");
4242
?>
4343
--EXPECT--
4444
array(4) {

ext/pdo/tests/bug_40285.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ echo "Done\n";
2828
<?php
2929
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3030
$db = PDOTest::factory();
31-
$db->exec("DROP TABLE test40285");
31+
PDOTest::dropTableIfExists($db, "test40285");
3232
?>
3333
--EXPECT--
3434
Done

ext/pdo/tests/bug_42917.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var_dump($res->fetchAll());
3030
<?php
3131
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
3232
$db = PDOTest::factory();
33-
$db->exec("DROP TABLE test42917");
33+
PDOTest::dropTableIfExists($db, "test42917");
3434
?>
3535
--EXPECT--
3636
array(5) {

0 commit comments

Comments
 (0)