Skip to content

Fix GH-10755: Memory leak in phar_rename_archive() #10848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GH-10755: Memory leak in phar_rename_archive() #10848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32f6625
Fix GH-10755: Memory leak in phar_rename_archive()
Mar 14, 2023
d78f767
Update push.yml
stkeke Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:
- PHP-8.1
- PHP-8.2
- master
- Trigger-branch
pull_request:
branches:
- '**'
Expand Down
3 changes: 2 additions & 1 deletion ext/phar/phar_object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2116,7 +2116,8 @@ static zend_object *phar_rename_archive(phar_archive_data **sphar, char *ext) /*
phar_destroy_phar_data(phar);
*sphar = NULL;
phar = pphar;
phar->refcount++;
/* FIX: GH-10755 Memory leak in phar_rename_archive() */
/* phar->refcount++; */
newpath = oldpath;
goto its_ok;
}
Expand Down
2 changes: 0 additions & 2 deletions ext/phar/tests/bug69958.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
--TEST--
Phar: bug #69958: Segfault in Phar::convertToData on invalid file
--XFAIL--
Still has memory leaks, see https://bugs.php.net/bug.php?id=70005
--EXTENSIONS--
phar
--FILE--
Expand Down