Additional clang-tidy suggestions

This is a big commit!

Lots of variable renaming, header removal and clang-format changes now
it aligns the equal signs on copy/move assigments correctly.

Author: php1ic

include/inch/chart.hpp

@@ -15,9 +15,8 @@
 
 #include <fmt/chrono.h>
 #include <fmt/format.h>
+#include <fmt/std.h>
 
-#include <cmath>
-#include <iostream>
 #include <string>
 #include <vector>
 
@@ -33,7 +32,7 @@ class Chart
   Chart(const Chart& Chart)     = default;
   Chart(Chart&& Chart) noexcept = default;
 
-  Chart& operator=(const Chart& Chart) = delete;
+  Chart& operator=(const Chart& Chart)     = delete;
   Chart& operator=(Chart&& Chart) noexcept = delete;
 
   virtual ~Chart() noexcept = default;
@@ -159,8 +158,7 @@ class Chart
    */
   [[nodiscard]] static inline std::string getTime()
   {
-    const std::time_t t = std::time(nullptr);
-    return fmt::format("{:%Y-%m-%dT%H:%M:%S}", *std::localtime(&t));
+    return fmt::format("{:%Y-%m-%dT%H:%M:%S}", fmt::localtime(std::time(nullptr)));
   }
 
   /**
@@ -200,6 +198,7 @@ class Chart
    * \return The height the canvas should be
    */
   [[nodiscard]] inline double
+  // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
   calculateCanvasHeight(const double key_scale, const double key_height, const int ZRange) const
   {
     double chart_height = ZRange + 2 * BORDER;

include/inch/dripline.hpp

@@ -100,6 +100,7 @@ class DripLine
   /// Container to hold each isotope in the drop model data file
   struct drop_model_data
   {
+    // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
     drop_model_data(const int mass_number, const int proton_number, const double mass_excess) :
         A(mass_number), Z(proton_number), N(mass_number - proton_number), ME(mass_excess)
     {

include/inch/eps_chart.hpp

@@ -26,7 +26,7 @@ class EPSChart : public Chart
   EPSChart(const EPSChart& EPSChart)     = default;
   EPSChart(EPSChart&& EPSChart) noexcept = default;
 
-  EPSChart& operator=(const EPSChart& EPSChart) = delete;
+  EPSChart& operator=(const EPSChart& EPSChart)     = delete;
   EPSChart& operator=(EPSChart&& EPSChart) noexcept = delete;
 
   ~EPSChart() noexcept override = default;

include/inch/eps_dripline.hpp

@@ -18,11 +18,8 @@
 
 #include <fmt/format.h>
 
-#include <filesystem>
-#include <fstream>
 #include <string>
 #include <utility>
-#include <vector>
 
 
 class EPSDripLine : public DripLine
@@ -38,7 +35,7 @@ class EPSDripLine : public DripLine
 
   /// Delete both due to const members
   EPSDripLine& operator=(const EPSDripLine&) = delete;
-  EPSDripLine& operator=(EPSDripLine&&) = delete;
+  EPSDripLine& operator=(EPSDripLine&&)      = delete;
 
   ~EPSDripLine() override = default;
 

include/inch/eps_grid.hpp

@@ -24,7 +24,7 @@ class EPSGrid : public Grid
   EPSGrid(const EPSGrid& EPSGrid)     = default;
   EPSGrid(EPSGrid&& EPSGrid) noexcept = default;
 
-  EPSGrid& operator=(const EPSGrid& EPSGrid) = default;
+  EPSGrid& operator=(const EPSGrid& EPSGrid)     = default;
   EPSGrid& operator=(EPSGrid&& EPSGrid) noexcept = default;
 
   ~EPSGrid() noexcept override = default;

include/inch/eps_key.hpp

@@ -16,8 +16,6 @@
 
 #include <fstream>
 #include <string>
-#include <utility>
-#include <vector>
 
 
 class Options;
@@ -30,7 +28,7 @@ class EPSKey : public Key
   EPSKey(const EPSKey& EPSKey) = default;
   EPSKey(EPSKey&& EPSKey)      = default;
 
-  EPSKey& operator=(const EPSKey& EPSKey) = default;
+  EPSKey& operator=(const EPSKey& EPSKey)     = default;
   EPSKey& operator=(EPSKey&& EPSKey) noexcept = default;
 
   ~EPSKey() noexcept override = default;

include/inch/eps_rProcess.hpp

@@ -10,10 +10,8 @@
 #include "inch/limits.hpp"
 #include "inch/rProcess.hpp"
 
-#include <filesystem>
 #include <string>
 #include <utility>
-#include <vector>
 
 class EPSrProcess : public rProcess
 {
@@ -24,7 +22,7 @@ class EPSrProcess : public rProcess
   EPSrProcess(EPSrProcess&&)      = default;
 
   EPSrProcess& operator=(const EPSrProcess&) = delete;
-  EPSrProcess& operator=(EPSrProcess&&) = delete;
+  EPSrProcess& operator=(EPSrProcess&&)      = delete;
 
   ~EPSrProcess() override = default;
 

include/inch/grid.hpp

@@ -21,7 +21,7 @@ class Grid
   Grid(const Grid& Grid)     = default;
   Grid(Grid&& Grid) noexcept = default;
 
-  Grid& operator=(const Grid& Grid) = default;
+  Grid& operator=(const Grid& Grid)     = default;
   Grid& operator=(Grid&& Grid) noexcept = default;
 
   virtual ~Grid() noexcept = default;

include/inch/io.hpp

@@ -26,7 +26,7 @@ class IO
   IO(IO&&)      = default;
 
   IO& operator=(const IO&) = default;
-  IO& operator=(IO&&) = default;
+  IO& operator=(IO&&)      = default;
 
   ~IO() = default;
 

include/inch/key.hpp

@@ -29,7 +29,7 @@ class Key
   Key(const Key& Key) = default;
   Key(Key&& Key)      = default;
 
-  Key& operator=(const Key& Key) = default;
+  Key& operator=(const Key& Key)     = default;
   Key& operator=(Key&& Key) noexcept = default;
 
   virtual ~Key() noexcept = default;