Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain PR checks that always fail #997

Open
lwcorp opened this issue Oct 5, 2023 · 7 comments
Open

Fix certain PR checks that always fail #997

lwcorp opened this issue Oct 5, 2023 · 7 comments

Comments

@lwcorp
Copy link
Contributor

lwcorp commented Oct 5, 2023

If someone tries to send a PR to your code, two commit checks always fail.

Steps to reproduce

  1. Edit a file or create a new one.
  2. Commit it.
  3. Send a PR.

Expected result
Pass all checks.

Actual outcome
The second and third checks from the end (7.2 and 7.3) always fail.
You can see them for further details in every open PR. The important part is it has nothing to do with the PR, but presented like it is (unless one clicks Details and reads carefully).

image

@lwcorp lwcorp changed the title Certain PR checks always fail Fix certain PR checks that always fail Oct 5, 2023
@michield
Copy link
Member

michield commented Nov 5, 2023

yes, that's why they are marked to "allow to fail". They fail on composer dependencies. We'll take them out soon

@lwcorp
Copy link
Contributor Author

lwcorp commented Nov 5, 2023

Where does it show "allow to fail"?

@michield
Copy link
Member

michield commented Nov 5, 2023

image

@lwcorp
Copy link
Contributor Author

lwcorp commented Nov 6, 2023

Do only admins see it?

@michield
Copy link
Member

michield commented Nov 6, 2023

Ah, don't know. Can you see it here? https://github.com/phpList/phplist3/actions/runs/6760239013

Also, the overall run has a blue tick, as opposed to a red one when all of them fail https://github.com/phpList/phplist3/actions

@lwcorp
Copy link
Contributor Author

lwcorp commented Nov 7, 2023

Some actions there have a fail icon and some "just" a warning.

In #994 for example to know it's okay not to pass some of these tests?

@michield
Copy link
Member

This is now ready for review in #1004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants