Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving files to php5 folder keeping the old links #60

Closed
wants to merge 1 commit into from
Closed

Conversation

thiagooak
Copy link
Contributor

Fixes #9

Creates a php5 folder while keeping the old links working using includes

If this approach makes sense I'll do it to the other files.

Was thinking of moving php7 up on the TOC also, but likely for another PR

@thiagooak
Copy link
Contributor Author

@nikic would it make sense to take this approach? or are y'all considering dropping the PHP5 content?

@jpauli
Copy link
Member

jpauli commented Nov 30, 2018

I don't think we will drop PHP 5 content, but have it clearly separated from PHP 7 (and future PHP 8) is a good thing IMO.

@nikic
Copy link
Collaborator

nikic commented Nov 30, 2018

My only concern here would be that the content is duplicated on two pages, rather one redirecting to the other. Do you know whether rst/sphinx also supports redirects (via JS probably?)

@thiagooak
Copy link
Contributor Author

I did some research on the redirect and it is doable with JS. There doesn't seem to be something baked into sphinx to do it. https://tech.signavio.com/2017/managing-sphinx-redirects

How painful would it be to just break those links? Is it fair to say that most people are now interested in PHP7? Would a 404 explaining the move be enough?

@thiagooak
Copy link
Contributor Author

Since I'm illiterate in python I wrote something in PHP to handle the redirects, it generates static files. Not exactly elegant, but I think it makes sense to have this as part of the "build" process and not part of the actual book.

@thiagooak thiagooak changed the title [WIP] Moving files to php5 folder keeping the old links Moving files to php5 folder keeping the old links Dec 1, 2018
@thiagooak
Copy link
Contributor Author

@jpauli @nikic what do you think of this?

@nikic
Copy link
Collaborator

nikic commented Dec 7, 2018

Looks like a reasonable approach to me. Someone will have to push a new build with this (unfortunately not automated...)

@nikic
Copy link
Collaborator

nikic commented Jun 27, 2019

Better late than never ... merged and pushed a new build. Redirects working great. Thanks for doing this!

@nikic nikic closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to PHP 7
3 participants