[WIP] Support Doctrine MongoDB ODM #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use generic ObjectManager naming * Make type extensions that differ for ODM more flexible
|
@alcaeus May we help you on this ? |
|
I've put work on hold since there are other PRs achieving the same thing and I haven't received any feedback from @ondrejmirtes on how to proceed. I'm not working on this until those questions are resolved to avoid doing work for nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.
This PR introduces compatibility with MongoDB ODM. A quick summary:
Entity*classes have been replaced by correspondingObject*classes. To avoid BC breaks, existing classes remain but throw a silenced deprecation warning so people can update their code if they extend those classesObjectManagerGetRepositoryDynamicReturnTypeExtensiontakes amanagerClassconstructor argument to be able to return different repository class names for ODM and ORM. The service configuration was updated to contain all three mappings fordoctrine/persistence,doctrine/ormanddoctrine/mongodb-odm.doctrine.repositoryClassparameter was renamed todoctrine.orm.repositoryClassto better differentiate it from the other class names. This can be reversed, although I'm not sure of a good way to throw a deprecation notice for this.Todos: