MockMethodCallRule - do not report for empty $mockClasses

phpstan · Mar 2, 2023 · 4cc5c6c · 4cc5c6c
1 parent 34ee324
commit 4cc5c6c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/Rules/PHPUnit/MockMethodCallRule.php b/src/Rules/PHPUnit/MockMethodCallRule.php
@@ -76,10 +76,15 @@ public function processNode(Node $node, Scope $scope): array
 				continue;
 			}
 
+			$classNames = $mockedClassObject->getObjectClassNames();
+			if (count($classNames) === 0) {
+				continue;
+			}
+
 			$errors[] = sprintf(
 				'Trying to mock an undefined method %s() on class %s.',
 				$method,
-				implode('|', $mockedClassObject->getObjectClassNames())
+				implode('|', $classNames)
 			);
 		}
 

diff --git a/tests/Rules/PHPUnit/data/mock-method-call.php b/tests/Rules/PHPUnit/data/mock-method-call.php
@@ -56,3 +56,18 @@ public function method(string $string)
 		return $string;
 	}
 };
+
+final class FinalFoo
+{
+
+}
+
+class FinalFooTest extends \PHPUnit\Framework\TestCase
+{
+
+	public function testMockFinalClass()
+	{
+		$this->createMock(FinalFoo::class)->method('doFoo');
+	}
+
+}