Revert "ArrayType::setOffsetValueType() - generalize item type if it …

…goes over a threshold" This reverts commit 10ba3c6.
phpstan · Sep 7, 2022 · 05dbd5e · 05dbd5e
1 parent ab7f8d2
commit 05dbd5e
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -285,15 +285,10 @@ public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $uni
 			$keyType = $keyType->generalize(GeneralizePrecision::moreSpecific());
 		}
 
-		$itemType = $valueType;
-		if ($unionValues) {
-			$itemType = TypeCombinator::union($this->itemType, $valueType);
-			if (count(TypeUtils::getConstantScalars($itemType)) > ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT) {
-				$itemType = $itemType->generalize(GeneralizePrecision::moreSpecific());
-			}
-		}
-
-		$array = new self($keyType, $itemType);
+		$array = new self(
+			$keyType,
+			$unionValues ? TypeCombinator::union($this->itemType, $valueType) : $valueType,
+		);
 		if ($offsetType instanceof ConstantIntegerType || $offsetType instanceof ConstantStringType) {
 			return TypeCombinator::intersect($array, new HasOffsetValueType($offsetType, $valueType), new NonEmptyArrayType());
 		}