Optimization?

phpstan · Apr 3, 2022 · 5400b58 · 5400b58
1 parent 91c7507
commit 5400b58
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -458,14 +458,24 @@ public function getOffsetValueType(Type $offsetType): Type
 	{
 		$offsetType = ArrayType::castToArrayKeyType($offsetType);
 		$matchingValueTypes = [];
+		$all = true;
 		foreach ($this->keyTypes as $i => $keyType) {
 			if ($keyType->isSuperTypeOf($offsetType)->no()) {
+				$all = false;
 				continue;
 			}
 
 			$matchingValueTypes[] = $this->valueTypes[$i];
 		}
 
+		if ($all) {
+			if (count($this->keyTypes) === 0) {
+				return new ErrorType();
+			}
+
+			return $this->getIterableValueType();
+		}
+
 		if (count($matchingValueTypes) > 0) {
 			$type = TypeCombinator::union(...$matchingValueTypes);
 			if ($type instanceof ErrorType) {