Match expression - do not complain about void in arm body

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -2492,7 +2492,7 @@ static function () use ($finalScope, $expr): MutatingScope {
 			$armNodes = [];
 			foreach ($expr->arms as $arm) {
 				if ($arm->conds === null) {
-					$armResult = $this->processExprNode($arm->body, $matchScope, $nodeCallback, $deepContext);
+					$armResult = $this->processExprNode($arm->body, $matchScope, $nodeCallback, ExpressionContext::createTopLevel());
 					$matchScope = $armResult->getScope();
 					$hasYield = $hasYield || $armResult->hasYield();
 					$throwPoints = array_merge($throwPoints, $armResult->getThrowPoints());
@@ -2529,7 +2529,7 @@ static function () use ($finalScope, $expr): MutatingScope {
 					$arm->body,
 					$matchScope->filterByTruthyValue($filteringExpr),
 					$nodeCallback,
-					$deepContext
+					ExpressionContext::createTopLevel()
 				);
 				$armScope = $armResult->getScope();
 				$scope = $scope->mergeWith($armScope);

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -1564,10 +1564,6 @@ public function testMatchExpressionVoidIsUsed(): void
 				'Result of method MatchExprVoidUsed\Foo::doBar() (void) is used.',
 				11,
 			],
-			[
-				'Result of method MatchExprVoidUsed\Foo::doBaz() (void) is used.',
-				11,
-			],
 		]);
 	}
 

tests/PHPStan/Rules/Methods/data/match-expr-void-used.php

@@ -9,6 +9,7 @@ public function doFoo($m): void
 	{
 		match ($this->doLorem()) {
 			$this->doBar() => $this->doBaz(),
+			default => $this->doBaz(),
 		};
 	}