Do not generate baseline when internal errors occured

Author: ondrejmirtes

src/Command/AnalyseApplication.php

@@ -96,6 +96,7 @@ public function analyse(
 		if (count($ignoredErrorHelperResult->getErrors()) > 0) {
 			$errors = $ignoredErrorHelperResult->getErrors();
 			$warnings = [];
+			$hasInternalErrors = false;
 		} else {
 			$resultCache = $this->resultCacheManager->restore($files, $debug);
 			$intermediateAnalyserResult = $this->runAnalyser(
@@ -111,6 +112,7 @@ public function analyse(
 			$internalErrors = $analyserResult->getInternalErrors();
 			$errors = $ignoredErrorHelperResult->process($analyserResult->getErrors(), $onlyFiles, $files, count($internalErrors) > 0 || $analyserResult->hasReachedInternalErrorsCountLimit());
 			$warnings = $ignoredErrorHelperResult->getWarnings();
+			$hasInternalErrors = count($internalErrors) > 0;
 			if ($analyserResult->hasReachedInternalErrorsCountLimit()) {
 				$errors[] = sprintf('Reached internal errors count limit of %d, exiting...', $this->internalErrorsCountLimit);
 			}
@@ -135,7 +137,8 @@ public function analyse(
 			$notFileSpecificErrors,
 			$warnings,
 			$defaultLevelUsed,
-			$projectConfigFile
+			$projectConfigFile,
+			$hasInternalErrors
 		);
 	}
 

src/Command/AnalyseCommand.php

@@ -205,6 +205,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
 				return $inceptionResult->handleReturn(1);
 			}
+			if ($analysisResult->hasInternalErrors()) {
+				$inceptionResult->getStdOutput()->getStyle()->error('An internal error occurred. Baseline could not be generated. Re-run PHPStan without --generate-baseline to see what\'s going on.');
+
+				return $inceptionResult->handleReturn(1);
+			}
 
 			$baselineFileDirectory = dirname($generateBaselineFile);
 			$baselineErrorFormatter = new BaselineNeonErrorFormatter(new ParentDirectoryRelativePathHelper($baselineFileDirectory));

src/Command/AnalysisResult.php

@@ -20,19 +20,23 @@ class AnalysisResult
 
 	private ?string $projectConfigFile;
 
+	private bool $hasInternalErrors;
+
 	/**
 	 * @param \PHPStan\Analyser\Error[] $fileSpecificErrors
 	 * @param string[] $notFileSpecificErrors
 	 * @param string[] $warnings
 	 * @param bool $defaultLevelUsed
 	 * @param string|null $projectConfigFile
+	 * @param bool $hasInternalErrors
 	 */
 	public function __construct(
 		array $fileSpecificErrors,
 		array $notFileSpecificErrors,
 		array $warnings,
 		bool $defaultLevelUsed,
-		?string $projectConfigFile
+		?string $projectConfigFile,
+		bool $hasInternalErrors
 	)
 	{
 		usort(
@@ -55,6 +59,7 @@ static function (Error $a, Error $b): int {
 		$this->warnings = $warnings;
 		$this->defaultLevelUsed = $defaultLevelUsed;
 		$this->projectConfigFile = $projectConfigFile;
+		$this->hasInternalErrors = $hasInternalErrors;
 	}
 
 	public function hasErrors(): bool
@@ -106,4 +111,9 @@ public function getProjectConfigFile(): ?string
 		return $this->projectConfigFile;
 	}
 
+	public function hasInternalErrors(): bool
+	{
+		return $this->hasInternalErrors;
+	}
+
 }

src/Testing/ErrorFormatterTestCase.php

@@ -78,7 +78,8 @@ protected function getAnalysisResult(int $numFileErrors, int $numGenericErrors):
 			$genericErrors,
 			[],
 			false,
-			null
+			null,
+			false
 		);
 	}
 

tests/PHPStan/Command/AnalysisResultTest.php

@@ -39,7 +39,8 @@ public function testErrorsAreSortedByFileNameAndLine(): void
 				[],
 				[],
 				false,
-				null
+				null,
+				false
 			))->getFileSpecificErrors()
 		);
 	}

tests/PHPStan/Command/ErrorFormatter/BaselineNeonErrorFormatterTest.php

@@ -131,7 +131,8 @@ public function testFormatErrorMessagesRegexEscape(): void
 			['Escape Regex without file # ~ <> \' ()'],
 			[],
 			false,
-			null
+			null,
+			false
 		);
 		$formatter->formatErrors(
 			$result,

tests/PHPStan/Command/ErrorFormatter/CheckstyleErrorFormatterTest.php

@@ -154,7 +154,8 @@ public function testTraitPath(): void
 			[],
 			[],
 			false,
-			null
+			null,
+			false
 		), $this->getOutput());
 		$this->assertXmlStringEqualsXmlString('<checkstyle>
 	<file name="FooTrait.php">