Constructor phpDocs are inherited without remapping parameter names by position

Author: ondrejmirtes

src/PhpDoc/PhpDocBlock.php

@@ -346,11 +346,18 @@ private static function resolvePhpDocBlockFromClass(
 				}
 				$methodVariants = $parentReflection->getVariants();
 				$positionalMethodParameterNames = [];
-				if (count($methodVariants) === 1) {
+				$lowercaseMethodName = strtolower($parentReflection->getName());
+				if (
+					count($methodVariants) === 1
+					&& $lowercaseMethodName !== '__construct'
+					&& $lowercaseMethodName !== strtolower($parentReflection->getDeclaringClass()->getName())
+				) {
 					$methodParameters = $methodVariants[0]->getParameters();
 					foreach ($methodParameters as $methodParameter) {
 						$positionalMethodParameterNames[] = $methodParameter->getName();
 					}
+				} else {
+					$positionalMethodParameterNames = $positionalParameterNames;
 				}
 			} else {
 				$traitReflection = null;

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -9742,6 +9742,11 @@ public function dataPhpDocInheritanceParameterRemapping(): array
 		return $this->gatherAssertTypes(__DIR__ . '/data/inheritdoc-parameter-remapping.php');
 	}
 
+	public function dataPhpDocInheritanceConstructors(): array
+	{
+		return $this->gatherAssertTypes(__DIR__ . '/data/inheritdoc-constructors.php');
+	}
+
 	public function dataListType(): array
 	{
 		return $this->gatherAssertTypes(__DIR__ . '/data/list-type.php');
@@ -9767,6 +9772,7 @@ public function dataListType(): array
 	 * @dataProvider dataBug2648
 	 * @dataProvider dataBug2740
 	 * @dataProvider dataPhpDocInheritanceParameterRemapping
+	 * @dataProvider dataPhpDocInheritanceConstructors
 	 * @dataProvider dataListType
 	 * @dataProvider dataBug2822
 	 * @param ConstantStringType $expectedType

tests/PHPStan/Analyser/data/inheritdoc-constructors.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace InheritDocConstructors;
+
+use function PHPStan\Analyser\assertType;
+
+class Foo
+{
+
+	/**
+	 * @param string[] $data
+	 */
+	public function __construct($data)
+	{
+		assertType('array<string>', $data);
+	}
+
+}
+
+class Bar extends Foo
+{
+
+	public function __construct($name, $data)
+	{
+		parent::__construct($data);
+		assertType('mixed', $name);
+		assertType('array<string>', $data);
+	}
+
+}