Add support for a not-deprecated annotation

This annotation allows disabling the inheritance of method deprecations
when a child class does not want to deprecate its method even though it
corresponds to a deprecated parent method.

Author: stof

src/PhpDoc/PhpDocNodeResolver.php

@@ -517,6 +517,13 @@ public function resolveIsDeprecated(PhpDocNode $phpDocNode): bool
 		return count($deprecatedTags) > 0;
 	}
 
+	public function resolveIsNotDeprecated(PhpDocNode $phpDocNode): bool
+	{
+		$notDeprecatedTags = $phpDocNode->getTagsByName('@not-deprecated');
+
+		return count($notDeprecatedTags) > 0;
+	}
+
 	public function resolveIsInternal(PhpDocNode $phpDocNode): bool
 	{
 		$internalTags = $phpDocNode->getTagsByName('@internal');

src/PhpDoc/ResolvedPhpDocBlock.php

@@ -103,6 +103,8 @@ class ResolvedPhpDocBlock
 
 	private ?bool $isDeprecated = null;
 
+	private ?bool $isNotDeprecated = null;
+
 	private ?bool $isInternal = null;
 
 	private ?bool $isFinal = null;
@@ -177,6 +179,7 @@ public static function createEmpty(): self
 		$self->selfOutTypeTag = null;
 		$self->deprecatedTag = null;
 		$self->isDeprecated = false;
+		$self->isNotDeprecated = false;
 		$self->isInternal = false;
 		$self->isFinal = false;
 		$self->isPure = null;
@@ -229,8 +232,9 @@ public function merge(array $parents, array $parentPhpDocBlocks): self
 		$result->typeAliasImportTags = $this->getTypeAliasImportTags();
 		$result->assertTags = self::mergeAssertTags($this->getAssertTags(), $parents, $parentPhpDocBlocks);
 		$result->selfOutTypeTag = self::mergeSelfOutTypeTags($this->getSelfOutTag(), $parents);
-		$result->deprecatedTag = self::mergeDeprecatedTags($this->getDeprecatedTag(), $parents);
+		$result->deprecatedTag = self::mergeDeprecatedTags($this->getDeprecatedTag(), $this->isNotDeprecated(), $parents);
 		$result->isDeprecated = $result->deprecatedTag !== null;
+		$result->isNotDeprecated = $this->isNotDeprecated();
 		$result->isInternal = $this->isInternal();
 		$result->isFinal = $this->isFinal();
 		$result->isPure = $this->isPure();
@@ -324,6 +328,7 @@ public function changeParameterNamesByMapping(array $parameterNameMapping): self
 		$self->selfOutTypeTag = $this->selfOutTypeTag;
 		$self->deprecatedTag = $this->deprecatedTag;
 		$self->isDeprecated = $this->isDeprecated;
+		$self->isNotDeprecated = $this->isNotDeprecated;
 		$self->isInternal = $this->isInternal;
 		$self->isFinal = $this->isFinal;
 		$self->isPure = $this->isPure;
@@ -599,6 +604,19 @@ public function isDeprecated(): bool
 		return $this->isDeprecated;
 	}
 
+	/**
+	 * @internal
+	 */
+	public function isNotDeprecated(): bool
+	{
+		if ($this->isNotDeprecated === null) {
+			$this->isNotDeprecated = $this->phpDocNodeResolver->resolveIsNotDeprecated(
+				$this->phpDocNode,
+			);
+		}
+		return $this->isNotDeprecated;
+	}
+
 	public function isInternal(): bool
 	{
 		if ($this->isInternal === null) {
@@ -871,14 +889,19 @@ private static function mergeSelfOutTypeTags(?SelfOutTypeTag $selfOutTypeTag, ar
 	/**
 	 * @param array<int, self> $parents
 	 */
-	private static function mergeDeprecatedTags(?DeprecatedTag $deprecatedTag, array $parents): ?DeprecatedTag
+	private static function mergeDeprecatedTags(?DeprecatedTag $deprecatedTag, bool $hasNotDeprecatedTag, array $parents): ?DeprecatedTag
 	{
 		if ($deprecatedTag !== null) {
 			return $deprecatedTag;
 		}
+
+		if ($hasNotDeprecatedTag) {
+			return null;
+		}
+
 		foreach ($parents as $parent) {
 			$result = $parent->getDeprecatedTag();
-			if ($result === null) {
+			if ($result === null && !$parent->isNotDeprecated()) {
 				continue;
 			}
 			return $result;

tests/PHPStan/Reflection/Annotations/DeprecatedAnnotationsTest.php

@@ -2,11 +2,14 @@
 
 namespace PHPStan\Reflection\Annotations;
 
+use DeprecatedAnnotations\Baz;
+use DeprecatedAnnotations\BazInterface;
 use DeprecatedAnnotations\DeprecatedBar;
 use DeprecatedAnnotations\DeprecatedFoo;
 use DeprecatedAnnotations\DeprecatedWithMultipleTags;
 use DeprecatedAnnotations\Foo;
 use DeprecatedAnnotations\FooInterface;
+use DeprecatedAnnotations\SubBazInterface;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Testing\PHPStanTestCase;
@@ -141,4 +144,13 @@ public function testDeprecatedMethodsFromInterface(): void
 		$this->assertTrue($class->getNativeMethod('superDeprecated')->isDeprecated()->yes());
 	}
 
+	public function testNotDeprecatedChildMethods(): void
+	{
+		$reflectionProvider = $this->createReflectionProvider();
+
+		$this->assertTrue($reflectionProvider->getClass(BazInterface::class)->getNativeMethod('superDeprecated')->isDeprecated()->yes());
+		$this->assertTrue($reflectionProvider->getClass(SubBazInterface::class)->getNativeMethod('superDeprecated')->isDeprecated()->no());
+		$this->assertTrue($reflectionProvider->getClass(Baz::class)->getNativeMethod('superDeprecated')->isDeprecated()->no());
+	}
+
 }

tests/PHPStan/Reflection/Annotations/data/annotations-deprecated.php

@@ -215,3 +215,26 @@ public function superDeprecated()
 	}
 
 }
+
+interface BazInterface
+{
+	/**
+	 * @deprecated Use the SubBazInterface instead.
+	 */
+	public function superDeprecated();
+}
+
+interface SubBazInterface extends BazInterface
+{
+	/**
+	 * @not-deprecated
+	 */
+	public function superDeprecated();
+}
+
+class Baz implements SubBazInterface
+{
+	public function superDeprecated()
+	{
+	}
+}