Do not narrow KernelTestCase::getContainer() return type to internal TestContainer

Author: VincentLanglet

extension.neon

@@ -13,9 +13,6 @@ parameters:
 		- stubs/Psr/Cache/CacheItemInterface.stub
 		- stubs/Psr/Cache/InvalidArgumentException.stub
 		- stubs/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/KernelBrowser.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/Test/TestContainer.stub
 		- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/AuthenticatorFactoryInterface.stub
 		- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FirewallListenerFactoryInterface.stub
 		- stubs/Symfony/Component/Console/Command.stub

src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

@@ -43,11 +43,11 @@ public function processNode(Node $node, Scope $scope): array
 
 		$argType = $scope->getType($node->var);
 
-		$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);
+		$isTestContainer = $this->isTestContainer($argType, $scope);
 		$isOldServiceSubscriber = (new ObjectType('Symfony\Component\DependencyInjection\ServiceSubscriberInterface'))->isSuperTypeOf($argType);
 		$isServiceSubscriber = $this->isServiceSubscriber($argType, $scope);
 		$isServiceLocator = (new ObjectType('Symfony\Component\DependencyInjection\ServiceLocator'))->isSuperTypeOf($argType);
-		if ($isTestContainerType->yes() || $isOldServiceSubscriber->yes() || $isServiceSubscriber->yes() || $isServiceLocator->yes()) {
+		if ($isTestContainer->yes() || $isOldServiceSubscriber->yes() || $isServiceSubscriber->yes() || $isServiceLocator->yes()) {
 			return [];
 		}
 
@@ -91,4 +91,25 @@ private function isServiceSubscriber(Type $containerType, Scope $scope): Trinary
 		return $isContainerServiceSubscriber->or($serviceSubscriberInterfaceType->isSuperTypeOf($containedClassType)->result);
 	}
 
+	private function isTestContainer(Type $containerType, Scope $scope): TrinaryLogic
+	{
+		$testContainer = new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer');
+		$isTestContainer = $testContainer->isSuperTypeOf($containerType)->result;
+
+		$classReflection = $scope->getClassReflection();
+		if ($classReflection === null) {
+			return $isTestContainer;
+		}
+
+		$containerInterface = new ObjectType('Symfony\Component\DependencyInjection\ContainerInterface');
+		$kernelTestCase = new ObjectType('Symfony\Bundle\FrameworkBundle\Test\KernelTestCase');
+		$containedClassType = new ObjectType($classReflection->getName());
+
+		return $isTestContainer->or(
+			$containerInterface->isSuperTypeOf($containerType)->result->and(
+				$kernelTestCase->isSuperTypeOf($containedClassType)->result,
+			),
+		);
+	}
+
 }

stubs/Symfony/Bundle/FrameworkBundle/KernelBrowser.stub

@@ -77,4 +77,14 @@ public function testGetPrivateServiceInServiceSubscriber(): void
 		);
 	}
 
+	public function testGetPrivateServiceInTest(): void
+	{
+		$this->analyse(
+			[
+				__DIR__ . '/ExampleTest.php',
+			],
+			[],
+		);
+	}
+
 }

stubs/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.stub

@@ -0,0 +1,23 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Symfony;
+
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+
+abstract class ExampleTest extends KernelTestCase
+{
+
+	public function bar(): void
+	{
+		$container = self::getContainer();
+		$container->get('private');
+	}
+
+	public function foo(KernelBrowser $browser): void
+	{
+		$container = $browser->getContainer();
+		$container->get('private');
+	}
+
+}