Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] phrase git_lab_sync history = ERROR: json: cannot unmarshal object into Go struct field GitlabSyncHistory.errors #372

Closed
horstmannmat opened this issue Jul 28, 2023 · 1 comment · Fixed by #373

Comments

@horstmannmat
Copy link
Contributor

Is exactly the same issue with #362, but with another field, it was not caught before, cause it was failing first at the status field

When executing the phrase git_lab_sync history in the latest version of the phrase-cli, it raises an error message:

ERROR: json: cannot unmarshal object into Go struct field GitlabSyncHistory.errors of type string

This seems to be related to a type mismatch between the model returned by the API and the model that the CLI is expecting
gitlab_sync_history.yaml#L10-L13

errors:
   type: array
   items:
       type: string

but the response is in fact an array of object

"errors":[
   {
      "error":"GitSync::Gitlab::Importer::UploadFailed",
      "message":"Unauthorized"
   }
],

I will once again create an MR to fix this

@theSoenke
Copy link
Collaborator

This should now be fixed in version 2.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants