feat(API): Introduce comment replies endpoints #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablan
approved these changes
Aug 23, 2023
| -H 'Content-Type: application/json' | ||
| - lang: CLI v2 | ||
| source: |- | ||
| phrase reactions create \ | ||
| --project_id <project_id> \ | ||
| --key_id <key_id> \ | ||
| --comment_id <comment_id> \ | ||
| --branch my-feature-branch \ | ||
| --data '{"branch":"my-feature-branch", "emoji": "👍"]}' \ |
There was a problem hiding this comment.
interesting, does this mean that branch can't be specified with a dedicated switch?
There was a problem hiding this comment.
@jablan I'm exactly wondering about this too. In some places we have --branch param and in some just the --data with branch inside 🤔 What do you think? How should we do this so it will definitely work?
There was a problem hiding this comment.
IMO it would be the best if CLI could have parameters specified through the dedicated switches, and translate that to JSON payload to the API, but not sure if that works and how.
Varpuspaavi
changed the title
Varpuspaavi
changed the title
Varpuspaavi
changed the title
Varpuspaavi
changed the title
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/phrase/phrase/pull/11643
https://memsourcegroup.atlassian.net/browse/TSE-869