Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update openapi-generator to v7 #418

Merged
merged 25 commits into from
Oct 30, 2023
Merged

Conversation

jablan
Copy link
Collaborator

@jablan jablan commented Oct 5, 2023

Big bump for openapi-generator from v4.3 to v7. Tried to keep the generated code as close as possible, by modifying the templates which have previously been dumped to openapi-generator/templates folder.

For comparing results, I was checking out another copy of this project, generating the libraries, and then running a recursive folder comparison tool.

@jablan jablan marked this pull request as ready for review October 9, 2023 08:46
@theSoenke
Copy link
Collaborator

@jablan great we could keep the existing interfaces with the latest generator 🔥 do you think it would make sense to add those tests first before we merge this to check that they pass before and after?

@jablan
Copy link
Collaborator Author

jablan commented Oct 9, 2023

@theSoenke that'd be great, if can be done in this sprint.

Copy link
Contributor

@hahmed-dev hahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part! Great Job!!

Copy link
Collaborator

@theSoenke theSoenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 also want to bump the library versions in this PR already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants