feat(CLI): Improve push error display [TSI-1736] #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSoenke
reviewed
Dec 14, 2023
clients/cli/cmd/internal/push.go
Outdated
| @@ -202,6 +209,9 @@ func (source *Source) Push(client *phrase.APIClient, waitForResults bool, branch | |||
| fmt.Fprintln(os.Stderr, strings.Repeat("-", 10)) | |||
| } | |||
| } | |||
| if !noErrors { | |||
| return errors.New("not_all_files_processed") | |||
There was a problem hiding this comment.
Maybe instead of an error code like looking message we could write a short sentence what happened?
There was a problem hiding this comment.
✔️ following other cases in the codebase, I rewrote this as a (semi)sentence
theSoenke
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several smaller improvements on push errors: