feat(CLI): Optional cleanup after push [TSI-2234] #518
Conversation
| @@ -209,13 +212,29 @@ func (source *Source) Push(client *phrase.APIClient, waitForResults bool, branch | |||
| fmt.Fprintln(os.Stderr, strings.Repeat("-", 10)) | |||
| } | |||
| } | |||
| if !noErrors { | |||
| if noErrors { | |||
| if waitForResults && cleanup { | |||
There was a problem hiding this comment.
Maybe you can show an error when the cleanup is passed but wait is missing? Otherwise it might cause some confusion why the cleanup didn't happen
clients/cli/cmd/internal/push.go
Outdated
| return errors.New("not all files were uploaded successfully") | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func cleanupAfterUpload(client *phrase.APIClient, projectId string, uploadIds []string) error { | ||
| cleanupCommand := &UploadCleanupCommand{ |
There was a problem hiding this comment.
How about putting the logic for deleting the keys into this method and then call it from the clean up command? Simulating a command to cleanup the keys feels a bit like the wrong way around
| commonUnmentionedKeys := map[string]phrase.TranslationKey{} | ||
| alreadyInitialized := false | ||
| for _, id := range cmd.IDs { | ||
| q := "unmentioned_in_upload:" + id |
There was a problem hiding this comment.
not related to the PR but noticed that this does not seem to return anything when an upload itself didn't change anything
There was a problem hiding this comment.
interesting. should we open a ticket? would that be TSS?
There was a problem hiding this comment.
Probably it would even for integrations as we own the API. I'll open a ticket to take a closer look
Addresses phrase/phrase-cli#22
We could reuse existing
UploadCleanupcommand. The tricky part is that a singlepushconsists of many uploads, each might contain a different set of keys. So, in order to properly cleanup unmentioned keys, we need to find an intersection of unmentioned keys for all uploads, and clean up only these. SoUploadCleanupis changed to accept an array of upload IDs, and getting the list of unmentioned keys (in batches) is now decoupled by deleting unmentioned keys (also in batches), with calculating intersection in between.