Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files downloaded by phrase pull should end with newline #130

Open
dkimmich-onventis opened this issue Aug 24, 2023 · 1 comment
Open

Files downloaded by phrase pull should end with newline #130

dkimmich-onventis opened this issue Aug 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dkimmich-onventis
Copy link

Files should end with newline, otherwise there can be issues with version control, such as unexpected results of diff and blame. When using phrase pull however, the file which is downloaded doesn't contain a final newline. If a code style tool like prettier is used, this causes a warning and can lead to additional work by the developer to either add a newline every time the file is downloaded, or exclude translation files from formatting.

The proposed solution is to add a final newline to the downloaded files.

@forelabs
Copy link
Member

forelabs commented Mar 8, 2024

Hi @dkimmich-onventis, first of all apologize the late reply.
We have discussed this internally and created an item for our product research.

For the current state I suggest to trigger a small script that adds the newline when you need it.

@forelabs forelabs removed their assignment Mar 8, 2024
@forelabs forelabs added the enhancement New feature or request label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants