Fix warnings triggered by raise_error matcher #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -299,7 +299,7 @@ def perform(sqs_msg, body); end | |||
| it 'does not extend the message invisibility' do | |||
| expect(sqs_msg).to receive(:visibility_timeout=).never | |||
| expect_any_instance_of(TestWorker).to receive(:perform).and_raise 'worker failed' | |||
| expect { subject.process(queue, sqs_msg) }.to raise_error | |||
| expect { subject.process(queue, sqs_msg) }.to raise_error(RuntimeError, "worker failed") | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Fix warnings that are triggered when the `raise_error` matcher is used without providing a specific error class or message. The warning quoted: >WARNING: Using the `raise_error` matcher without providing a specific error or >message risks false positives, since `raise_error` will match when Ruby raises >a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the >expectation to pass without even executing the method you are intending to >call. Instead consider providing a specific error class or message. This >message can be supressed by setting: >`RSpec::Expectations.configuration.warn_about_potential_false_positives = >false`.
| @@ -33,7 +35,9 @@ | |||
|
|
|||
| expect(sqs_msg).not_to receive(:change_visibility) | |||
|
|
|||
| expect { subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise } }.to raise_error | |||
| expect { | |||
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
phstc
added a commit
that referenced
this pull request
Oct 19, 2015
Fix warnings triggered by raise_error matcher
|
Cool. Added to master 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings that are triggered when the
raise_errormatcheris used without providing a specific error class or message.
The warning quoted: