Add explanation about configure_client and configure_server #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3poteto
changed the title
configure_client and configure_server
phstc
reviewed
Dec 9, 2016
| secret_access_key: ..., # or ENV["AWS_SECRET_ACCESS_KEY"] | ||
| access_key_id: ..., # or ENV["AWS_ACCESS_KEY_ID"] | ||
| region: "us-east-1", # or ENV["AWS_REGION"] | ||
| receive_message: { # See http://docs.aws.amazon.com/sdkforruby/api/Aws/SQS/Client.html#receive_message-instance_method |
There was a problem hiding this comment.
@h3poteto thanks for the update! 🍻
I think we could remove the sqs_endpoint and sns_endpoint from the example above, it can mislead people making the believe it's required, usually they just want to copy&paste and try to fill that information, I guess most don't know about these endpoints, WDYT?
There was a problem hiding this comment.
OK, I agree. Those options are written over there:https://github.com/phstc/shoryuken/pull/283/files#diff-04c6e90faac2675aa89e2176d2eec7d8R162
so it is not necessary to write them here.
I will remove.
|
@h3poteto thanks! Added to master 🍻
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shoryuken v2.1.0can useconfigure_clientandconfigure_serverto setup aws.So, I add explanation that in README.
I will update the wiki later.