Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for duplicate taxon labels #18

Open
gaurav opened this issue Jan 5, 2017 · 1 comment
Open

Add support for duplicate taxon labels #18

gaurav opened this issue Jan 5, 2017 · 1 comment
Assignees

Comments

@gaurav
Copy link
Member

gaurav commented Jan 5, 2017

DendroPy cannot load a phylogeny with duplicate taxon labels, which means that phylo2owl.py can't, either. Fixing this will mean moving away from our previous model of naming leaf nodes from the taxon name (e.g. "pg_2357:Alobevania_gattiae") to using the same Node-number scheme we use for internal nodes (e.g. "pg_2357:Node_134"), and then providing them with either an rdfs:label or making them explicit instances of cdao:TU and figuring out the best name of assigning taxonomic names to those.

@hlapp
Copy link
Member

hlapp commented Jan 6, 2017

I think that's a good thing to do anyway. Abusing labels for identifiers is fine for getting a proof of concept started, but is still an abuse. So I agree let's start to think more thoroughly about what the model for describing OTUs should look like.

There's some work I've done previously that's somewhat related, in that it proposes a model for annotating OTUs (in this case with TNRS matches): https://github.com/phylotastic-legacy/ontologies/tree/master/tnrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants