Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a type for apomorphies in TaxonomicUnitWrapper #28

Closed
gaurav opened this issue Jul 3, 2019 · 2 comments · Fixed by #72
Closed

Add a type for apomorphies in TaxonomicUnitWrapper #28

gaurav opened this issue Jul 3, 2019 · 2 comments · Fixed by #72
Labels
programming only No discussion necessary; just pure programming needed

Comments

@gaurav
Copy link
Member

gaurav commented Jul 3, 2019

TaxonomicUnitWrapper has a TYPE_TAXON_CONCEPT and a TYPE_SPECIMEN. We should add a TYPE_APOMORPHY for specifiers that are apomorphies.
@gaurav gaurav added the programming only No discussion necessary; just pure programming needed label Aug 8, 2019
@hlapp
Copy link
Member

hlapp commented Oct 9, 2020

I agree http://purl.obolibrary.org/obo/CDAO_0000071 is a good candidate. It's certainly not wrong, and I'm not sure we need a more specific type than that.

@hlapp
Copy link
Member

hlapp commented Feb 5, 2021

I agree http://purl.obolibrary.org/obo/CDAO_0000071 is a good candidate.

I'm not so sure anymore, actually. An apomorphy is really a character state, a phenotype, not a character. Maybe use something neutral, such as https://semanticscience.org/resource/SIO_010056.

@gaurav gaurav mentioned this issue Mar 8, 2021
Merged
@gaurav gaurav closed this as completed in #72 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
programming only No discussion necessary; just pure programming needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add apomorphy-based phyloref phyloref/phyx.js
2 participants
@gaurav @hlapp