Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping pihole-FTL process returns non-zero exit code #516

Closed
mbiebl opened this issue Feb 19, 2019 · 1 comment
Closed

Stopping pihole-FTL process returns non-zero exit code #516

mbiebl opened this issue Feb 19, 2019 · 1 comment

Comments

@mbiebl
Copy link

mbiebl commented Feb 19, 2019

When running pihole-FTL in foreground mode (via -f), stopping the process via kill, will terminate the process, stop successfully, but then returns -1. This makes it hard to use pihole-FTL with a different service manager like runit or systemd, as they will mark the process as failed on stop.
To reproduce the issue, run

# runuser -u pihole /usr/bin/pihole-FTL -- -f
(run kill $(pid_of pihole-FTL) )
# echo $?
1

The logs show that pihole-FTL did shutdown properly:

# tail -n 3 /var/log/pihole-FTL.log 
[2019-02-19 20:00:52.430 535] Shutting down...
[2019-02-19 20:00:52.844 535] Finished final database update
[2019-02-19 20:00:52.846 535] ########## FTL terminated after 24204.6 ms! ##########

...
@dschaper dschaper transferred this issue from pi-hole/pi-hole Feb 19, 2019
@DL6ER
Copy link
Member

DL6ER commented May 26, 2019

This is fixed since v4.3

@DL6ER DL6ER closed this as completed May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants