Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adlist group management design problem (width) #1414

Closed
3 tasks done
beerisgood opened this issue May 15, 2020 · 5 comments
Closed
3 tasks done

Adlist group management design problem (width) #1414

beerisgood opened this issue May 15, 2020 · 5 comments

Comments

@beerisgood
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

UI should work, no matter if sidebar is minimised or not
Screenshot:
fixed UI

Actual behaviour:

UI break if sidebar isn't minimised
Screenshot:
broken UI

Steps to reproduce:

in PiHole Web interface "Group Management" -> "Adlists" -> on right side the UI is broken

Debug token provided by uploading pihole -d log:

not needed

Troubleshooting undertaken, and/or other relevant information:

  • clear browser (Microsoft Edge) cache -> no solution
  • minimise PiHole sidebar -> solution
@celebrir
Copy link

celebrir commented May 21, 2020

Same on my end.
As soon as I added a very long url to the adlist and it causes the <section class="content"> to be horizontally scrollable. The URLs do a line break at a dash in my case but should do them more frequently.

@beerisgood
Copy link
Author

@pi-hole

@dschaper dschaper transferred this issue from pi-hole/pi-hole May 30, 2020
@celebrir
Copy link

Welp, apparently it's the same for the Audit log. I'll assume it's a general flaw of the respective container displaying the addresses.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@yubiuser
Copy link
Member

This issue was solved by: #1161

(But in turn led to issue #1458)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants