Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bind context #35

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: bind context #35

merged 1 commit into from
Jul 18, 2024

Conversation

mahansky
Copy link
Contributor

@Perdolique
Copy link
Contributor

Perdolique commented Jul 17, 2024 •
edited
Loading

Just checked on my local environment and it works. #30 was fixed👍

dario-piotrowicz
dario-piotrowicz approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! thanks a lot @mahansky ❤️

pi0
pi0 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit dfa92e7 into nitrojs:main Jul 18, 2024
2 checks passed
@pi0
Copy link
Member

pi0 commented Jul 18, 2024 •
edited
Loading

Landed in v0.1.6

@pi0 pi0 mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

does the service binding not work in dev? Nuxt dies in dev mode after using createError
4 participants
@mahansky @Perdolique @pi0 @dario-piotrowicz