Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update released version? #184

Open
mattloose opened this issue Oct 6, 2023 · 16 comments
Open

Update released version? #184

mattloose opened this issue Oct 6, 2023 · 16 comments

Comments

@mattloose
Copy link

Hi,

This is a great library - do you have plans to push an update to pypi soon supporting some of the recent changes? Other libraries building on this would benefit!

Thanks!

@piccolomo
Copy link
Owner

piccolomo commented Oct 7, 2023

Hi apologies, I am working on version 6 by rewriting the code from scratch, and hopefully working on issue later.

The code needs refreshing (especially in the _build.py file which is mysterious to read by me even),

It is not going particularly fast. Anything you need particular updates on?

@mattloose
Copy link
Author

Thanks!

I'm using the recent textual wrapper to plotext - this uses the pypi version which doesn't include the option to label stacked bar plots.

It would be cool if it did in future!

@piccolomo
Copy link
Owner

piccolomo commented Oct 8, 2023

Ok, thanks for replying.

I will try to work on labelled bar plots. For now the way to do it, is 'manually', as shown here.

I hope it helps in the meantime.
Savino

@blochl
Copy link

blochl commented Jan 17, 2024

It also would be awesome to have a released version with heatmap support...

@ap--
Copy link

ap-- commented Apr 25, 2024

Hi @piccolomo,

First, thanks for this great library ❤️ and sorry for bumping this issue.
It would be wonderful if the current version on master could just be released as 5.3.1.
If there are any open issues that would block a pre v6 release, I would be happy to contribute time.

Cheers,
Andreas 😃

@piccolomo
Copy link
Owner

piccolomo commented Apr 27, 2024

Hi @ap--

yes sorry you and others if waiting for version 6. I got derailed into rewriting the kernel of the program and it is taking more time then expected. But I am working on it (in spare time).

You are welcomed to contribute. You could write me by email (piccolomo@gmail.com) and see how you could help.

Thanks for the message,
Savino

@piccolomo
Copy link
Owner

Just to update and apologise: I have been quite busy rewriting the package from ground up and will update.

@luxedo
Copy link

luxedo commented Sep 15, 2024

I discovered this package last week and it has been a lifesaver for my hobby project. Thank you!

I'd love to use the box in my project but it seems it has not been released yet at PyPI. If there's anything I can do to help release 5.3.1 please let me know.

@piccolomo
Copy link
Owner

piccolomo commented Sep 16, 2024

Hi @luxedo and all,

so basically I have been working not stop (when I got the time) to build the project from ground up. Reason is: I was not happy with plotext kernel: it works but it is messy. I did not expect it to be this laborious! Dang it! It has been many months!

Again apologies and thank you for patience!

Here is the progress:

  • the plotting kernel is ready! basically the plot central part, where data is plotted in colours and optionally with higher definition characters. This was the most difficult part and it took so much effort and time to do it properly

  • I am now building the easy part: upper and lower bars, axis, numerical ticks and connect them in one coherent plot (end of September)

  • Next difficult step is having subplots but I have the rough code rewritten already (mid or end of October)

  • From there I have to add all types of extra plots, like bar and box plot (end of November)

  • revise command line tool (no much to change there), add documentation and extra details (end of December)

  • Answer issues and PLs, package it and publish: (end of January)

It is going to take a while, especially cause I want to do it properly! I have added a rough estimate of delivery times. The estimate is pessimistic (I hope!).

I have lost memory of the state of plotext as it is now on GitHub. What I can do is publish it on test pypi and give you the link so you can check if all works fine.

Once you happy with it I can publish it on pypi.

Would you be available? You would have to test the package. Would that work? I would appreciate it cause I am focused on new version.

Thank you!
Savino

@luxedo
Copy link

luxedo commented Sep 17, 2024

Yes I can take a look. I see there's a few tests in https://github.com/piccolomo/plotext/blob/master/tests.sh and it could be a start

@piccolomo
Copy link
Owner

piccolomo commented Sep 17, 2024

Hi @luxedo,

here is version 5.3.1 on testpypi. Those tests are a good starting point.

Thank you very much! :-)

@luxedo
Copy link

luxedo commented Sep 21, 2024

Plotext 5.3.1 tests

TLDR;
Here are the outputs of the test script
test_report_split1.txt
test_report_split2.txt

It seems that everything is working except for the YouTube tests. Also, a coulple of plot's I'm working on were perfect.

Installing

To install the package I had to add --extra-index for getting some dependencies from regular PyPI. Also, for some reason when I tried to install it was always in version 4.2.0, so I had to specify 5.3.1.

pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple 'plotext[video]==5.3.1'

Running test command

Running the test script for the first time freezes the script in both YouTube Plot tests:

echo -en "Command Line Tool: YouTube Plot"
fork
if test $out -eq 1
then
    plotext youtube --url test
fi
# And
echo -en "YouTube Plot"
fork
if test $out -eq 1
then
    python3 -c "import plotext as plt; plt.play_youtube(plt.test_youtube_url)"
fi

Freezes here with the following message:

yes | ./tests.sh > test_report.txt

[ WARN:0@0.124] global cap.cpp:164 open VIDEOIO(CV_IMAGES): raised OpenCV exception:

OpenCV(4.10.0) /io/opencv/modules/videoio/src/cap_images.cpp:244: error: (-5:Bad argument) CAP_IMAGES: error, expected '0?[1-9][du]' pattern, got: https://rr2---sn-oxunxg8pjvn-jfcy.googlevideo.com/videoplayback?expire=1726952297&ei=Cd_uZqC8AZXb1sQP-KKouAw&ip=2804%3A14c%3A482%3A4f51%3A0%3A0%3A0%3A7990&id=o-AIQYfLTbAa_wKlrk4tKeSTGMD4VCuWm63Y87eHYNy6ed&itag=18&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=tC&mm=31%2C29&mn=sn-oxunxg8pjvn-jfcy%2Csn-bg0s7nl6&ms=au%2Crdu&mv=m&mvi=2&pcm2cms=yes&pl=55&initcwndbps=1397500&bui=AXLXGFTrjvHJurxagIcmWjKf97paCVZtEVMjyjif9T1caYY5N6Tgo2NPiXqVTWTSyzdElN6xYEPLbUs5&spc=54MbxXgkMHtEV43WZ0DRiMIZsapeG8BFejY8Ki3VZpRh1Zvy0txQkeocciPTHVc&vprv=1&svpuc=1&mime=video%2Fmp4&ns=UfSMIpvi_QfYZqiGxCFPW8MQ&rqh=1&gir=yes&clen=59468543&ratebypass=yes&dur=1231.145&lmt=1698606074678367&mt=1726930383&fvip=4&c=WEB&sefc=1&txp=4438434&n=q-8e_0X-UewMwTP6A&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cbui%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Crqh%2Cgir%2Cclen%2Cratebypass%2Cdur%2Clmt&sig=AJfQdSswRQIgM_l2a6GKYrCBCLnqJHgp225d6B4Oxqhhm5hGPmB8mX0CIQCcRX7A5aEx6obRCKFnH_b0t3PcrP2p8AtgYr5xe6TOGQ%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Cinitcwndbps&lsig=ABPmVW0wRgIhAP02772Id0shTtbd_Bc3a-CbvWkJ9G5vfspfb9LRuu4UAiEAwWk-e6rSF0cFJ5b1jxeHCEv_wbv6GX0IV_PelV5B7J0%3D in function 'icvExtractPattern'


[https @ 0x7aac08001880] HTTP error 403 Forbidden
https://rr2---sn-oxunxg8pjvn-jfcy.googlevideo.com/videoplayback?expire=1726952297&ei=Cd_uZqC8AZXb1sQP-KKouAw&ip=2804%3A14c%3A482%3A4f51%3A0%3A0%3A0%3A7990&id=o-AIQYfLTbAa_wKlrk4tKeSTGMD4VCuWm63Y87eHYNy6ed&itag=18&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=tC&mm=31%2C29&mn=sn-oxunxg8pjvn-jfcy%2Csn-bg0s7nl6&ms=au%2Crdu&mv=m&mvi=2&pcm2cms=yes&pl=55&initcwndbps=1397500&bui=AXLXGFTrjvHJurxagIcmWjKf97paCVZtEVMjyjif9T1caYY5N6Tgo2NPiXqVTWTSyzdElN6xYEPLbUs5&spc=54MbxXgkMHtEV43WZ0DRiMIZsapeG8BFejY8Ki3VZpRh1Zvy0txQkeocciPTHVc&vprv=1&svpuc=1&mime=video%2Fmp4&ns=UfSMIpvi_QfYZqiGxCFPW8MQ&rqh=1&gir=yes&clen=59468543&ratebypass=yes&dur=1231.145&lmt=1698606074678367&mt=1726930383&fvip=4&c=WEB&sefc=1&txp=4438434&n=q-8e_0X-UewMwTP6A&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cbui%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Crqh%2Cgir%2Cclen%2Cratebypass%2Cdur%2Clmt&sig=AJfQdSswRQIgM_l2a6GKYrCBCLnqJHgp225d6B4Oxqhhm5hGPmB8mX0CIQCcRX7A5aEx6obRCKFnH_b0t3PcrP2p8AtgYr5xe6TOGQ%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Cinitcwndbps&lsig=ABPmVW0wRgIhAP02772Id0shTtbd_Bc3a-CbvWkJ9G5vfspfb9LRuu4UAiEAwWk-e6rSF0cFJ5b1jxeHCEv_wbv6GX0IV_PelV5B7J0%3D: Server returned 403 Forbidden (access denied)

The version 5.2.8 also prouces this error. After removing the YouTube tests, all the other seems to build a coherent plot.

@piccolomo
Copy link
Owner

I see : I am going to publish it regardless on pypi and deal with this video streaming issue for next version, as it is not central to the package.

Let me know if you or anyone else does not agree.

Thank you for the tests!

@piccolomo
Copy link
Owner

Published on pypi!

:-)

@Zaloog
Copy link

Zaloog commented Sep 22, 2024

Unfortunately the new release is breaking textual-plotext, a wrapper library to use plotext plots in textual, the actual code changes are not in github yet correct?

Best regards, and thanks for this awesome library and the work you put into it

@piccolomo
Copy link
Owner

piccolomo commented Oct 8, 2024

Hi @luxedo, @Zaloog I removed some posts about textual-plotext, cause they were too many and a bit off topic. Long story short: it does not seem to work (or it works in some cases) and solution is not found yet. But I am still interested in a solution.

Repository owner deleted a comment from Zaloog Oct 8, 2024
Repository owner deleted a comment from luxedo Oct 8, 2024
Repository owner deleted a comment from luxedo Oct 8, 2024
Repository owner deleted a comment from Zaloog Oct 8, 2024
Repository owner deleted a comment from luxedo Oct 8, 2024
Repository owner deleted a comment from Zaloog Oct 8, 2024
Repository owner deleted a comment from luxedo Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants