Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit farm components #100

Closed
janklimo opened this issue Jan 21, 2022 · 3 comments
Closed

Audit farm components #100

janklimo opened this issue Jan 21, 2022 · 3 comments

Comments

@janklimo
Copy link
Contributor

Can we please review farm components returned by core? Noticed them missing for Curve farms, Liquity, maybe more. See pickle-finance/pickle-ui#294 (comment)
@janklimo janklimo mentioned this issue Mar 8, 2022
Closed
@robstryker
Copy link
Contributor

Please be more specific. Do you need asset/depositToken/components? or asset/depositToken/componentTokens? or both? Are both strictly required? As i understand it we've had problems getting the component token counts.

@robstryker
Copy link
Contributor

List of jars with no components:
sCRV
renBTCCRV
3poolCRV
steCRV
undefined
ALETH
LQTY
LOOKS

@robstryker
Copy link
Contributor

I purposely didn't give components to alETH, so that you may ensure you have properly handled disabled jars with no components listed... and also bc i have no idea wtf was supposed to be in it or where those tokens are, and I think it's stupid to add them to the token model when the jar never launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robstryker @janklimo