-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language parameter has no effect #260
Comments
I'm sorry you are having problems, and thank you for taking the time to report this. I am on the road now, but will investigate this evening. |
I had a quick look at your feature files (on a mac so I can't run Pickles :-( ) - could you try adding a language header to the dutch feature file? Add
as the first line of the feature file (as described at https://github.com/cucumber/cucumber/wiki/Spoken-languages). |
Adding a language instruction on the first line works. Is this how it should behave? I'm already passing "nl" as the default language: pickles.exe -l=nl |
Passing the language parameter should work, so there is a problem somewhere. But at least now you have a fallback option. Do you use any other gherkin/cucumber/specflow related tools? How do they deal with Dutch feature files? |
We use SpecFlow (v1.9.0) which handles the feature files without any issues. |
The problem occurs in the parser we use to read the feature files. That is an external component that was recently changed (in fact, it was the reason the version number went to 2.x). I reached out to the team that maintains the parser and asked them what the new version of the parser expects. Pickles 1.x and SpecFlow 1.9.0 both use the old version of the parser, so that may explain why those tools work as expected. In any case, I am now waiting for a reply and I will get back to you when I hear from the other team. |
Alright, thanks! |
I heard back from the Gherkin people and they pointed me in the right direction. I will release a new version with the fix later today. |
Released in version 2.2.0. |
Top notch! It works like a charm. |
Thank you, I'm glad I could help! |
I noticed that after upgrading to version 2.x my Dutch feature files are no longer recognized. This used to work in version 1.2.3.
The DirectoryTreeCrawler throws a warning stating the file could not be read in properly.
Reproduction: http://www.marcwils.be.eu.org/wp-content/uploads/2016/01/dutchpickles.zip
The text was updated successfully, but these errors were encountered: