Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_logs fails if any password contains slashes #253

Open
pjones opened this issue Mar 26, 2024 · 0 comments
Open

copy_logs fails if any password contains slashes #253

pjones opened this issue Mar 26, 2024 · 0 comments
Labels

Comments

@pjones
Copy link

pjones commented Mar 26, 2024

If any of the password variables (LUKS_PASSWORD, ROOT_PASSWORD, or USER_PASSWORD) contains a slash it will break the sed replacement and the alis.sh script will fail with an error.

Also, the copy_logs function contains a lot of redundancy. The body of the function could easily be wrapped in a loop.

Thank you for this project. It saved me a lot of time today. I wish I had time to submit a patch but I don't currently have any free time. If this is still open in a few weeks I will try to come back around and solve it.

@picodotdev picodotdev added the bug label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants