Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product entity is missing a function and some parmeters #247

Open
dario-dib opened this issue Jul 30, 2021 · 4 comments
Open

Product entity is missing a function and some parmeters #247

dario-dib opened this issue Jul 30, 2021 · 4 comments

Comments

@dario-dib
Copy link
Contributor

Hi!

It looks like the Product entity is missing some parameters (title, identifier, product_type).

Also there is no function for /products/identifier/:identifier

Can you please add it? Or give me the permissions to create a branche/pull request? Thanks a lot!

/**

  • @var array
    */
    protected $fillable = [
    'id',
    'title',
    'description',
    'price',
    'currency',
    'frequency',
    'frequency_type',
    'tax_rate_id',
    'ledger_account_id',
    'identifier',
    'product_type',
    'created_at',
    'updated_at',
    ];

/**

  • @param string|int $identifier

  • @return static

  • @throws ApiException
    */
    public function findByIdentifier($identifier)
    {
    $result = $this->connection()->get($this->getEndpoint() . '/identifier/' . urlencode($identifier));

    return $this->makeFromResponse($result);
    }

.

@ralphjsmit
Copy link

Yes, would be awesome if this could be added!

@dario-dib
Copy link
Contributor Author

@ralphjsmit I've forked it, since there is no reaction. Check : https://github.com/dario-dib/moneybird-php-client

@ralphjsmit
Copy link

That's nice, thanks Dario!

@dario-dib
Copy link
Contributor Author

I've created a pull request for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants