Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty seperator does not work as option #116

Open
ghost opened this issue Jan 10, 2018 · 2 comments
Open

Empty seperator does not work as option #116

ghost opened this issue Jan 10, 2018 · 2 comments
Assignees
@pid

Comments

@ghost
Copy link

ghost commented Jan 10, 2018

const input = "-ä ß üö,.";
const separator = "";
let res = getSlug(input, { separator: separator});
console.log(res); // ae-ss-ueoe
res = getSlug(input, separator);
console.log(res); // -aessueoe

When the seperator is not empty it gives correct results (-ae+ss+ueoe).
@pid pid self-assigned this Mar 20, 2018
@kwiatkk1 kwiatkk1 mentioned this issue Oct 19, 2018
Open
@kwiatkk1
Copy link
Contributor

Hi, I just made a change that tackles this. See #125 .

@chartrand22
Copy link

This fix is still not available in any speakingurl release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pid pid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pid @kwiatkk1 @chartrand22