Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to identify one of three visible ocean monuments, why two of them and not the third? #79

Open
rkiddy opened this issue Apr 24, 2022 · 3 comments

Comments

@rkiddy
Copy link

rkiddy commented Apr 24, 2022

Environment info

  • BlockMap version: 2.4.1
  • Minecraft version: 1.18.2
  • Java version: 18.0.1 2022-04-19 (build 18.0.1+10-24)
  • Operating system: macOS 11.3.1 (20E241)

Description

I have a little section of the map where there are 3 ocean monuments. For some reason, only two of them are marked with icons. The other one was showing up (before a reboot and whatever else).

Screenshots

Screen Shot 2022-04-24 at 2 31 46 PM

The little dot-thing in the bottom-left is the 3rd ocean monument.
@piegamesde
Copy link
Owner

This is weird. It would be cool if you could find out what exactly made the third one disappear, or if you can make it reappear somehow; and whether other structures or pins are affected too.

If you're not afraid of touching code, you could try to check in the ChunkMetadata whether the structure is simply not found or whether it is found but not displayed correctly.

@rkiddy
Copy link
Author

rkiddy commented Apr 24, 2022

I can do code. Can you describe (at a high-level) where I should look at the chunks at some position or of some type, or both?

@piegamesde
Copy link
Owner

The data is extracted in the ChunkRenderer class.

If you go for it from an outside perspective, you have a RegionFolder which will render your region files. Each Region has some ChunkMetadata for each of its chunks. In case the chunk actually got rendered the structures extracted from the renderer will be put there.

If you want to dig the GUI code check for some "pin" and "decoration" related classes, but I wouldn't recommend it for a start 🙈.

For a start, maybe try snooping all structures within the rendering itself using print statements and see whether all of your ocean monuments show up in there. If that's the case, slowly work up your way the data processing chain. Otherwise, try to find out what happens in the chunk with the missed monument and why it is not recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants