Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue when loading transcript in paper edit #14

Open
pietrop opened this issue Feb 18, 2020 · 5 comments
Open

Performance issue when loading transcript in paper edit #14

pietrop opened this issue Feb 18, 2020 · 5 comments
Assignees
Labels
bug Something isn't working Refactoring

Comments

@pietrop
Copy link
Owner

pietrop commented Feb 18, 2020

There's a performance issue when loading transcript in paper edit.

The current way of adding highlights is very process intense and triggers the debugger coz it's running out of memory when used in Adobe CEP Panel.

Screen Shot 2020-02-18 at 10 32 10 AM

Raising it here as opposed to the DPE Adobe CEP Panel repo, coz it has to be addressed in the React component that does the highlights interpolation in the transcription's text

@pietrop pietrop added the bug Something isn't working label Feb 18, 2020
@pietrop pietrop self-assigned this Feb 18, 2020
@pietrop
Copy link
Owner Author

pietrop commented Feb 18, 2020

one workaround while finding a solution, might be to disable the highlights feature as a way to do a working release. and then re-introduce it once performance has been fixed.

@pietrop
Copy link
Owner Author

pietrop commented Feb 18, 2020

Adding a delay so that it adds the transcripts with the highlights after the components is mounted see this commit for details fbb5b61

Tested in adobe CEP, still a bit sluggish but at least the page loads...

Screen Shot 2020-02-18 at 4 43 27 PM

@pietrop
Copy link
Owner Author

pietrop commented Feb 19, 2020

while I can figure out a better way to avoid for the transcript / annotation interpolation to take up soo much memory, I added a btn to delay the process, and do them one at a time as a workaround when working with Adobe CEP

Screen Shot 2020-02-19 at 4 40 51 PM

@pietrop
Copy link
Owner Author

pietrop commented May 22, 2020

Should test this after having added code splitting

@pietrop
Copy link
Owner Author

pietrop commented Apr 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Refactoring
Projects
None yet
Development

No branches or pull requests

1 participant