Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function name toolSplitBiomass is duplicated #49

Open
ricardarosemann opened this issue Dec 6, 2024 · 1 comment · May be fixed by #50
Open

Function name toolSplitBiomass is duplicated #49

ricardarosemann opened this issue Dec 6, 2024 · 1 comment · May be fixed by #50
Assignees
@robinhasse @ricardarosemann

Comments

@ricardarosemann
Copy link
Contributor

There are two different functions called toolSplitBiomass in the madrat-verse, one in mrcommons and one in mredgebuildings. I would suggest to rename one of the two in order to be able to use both - otherwise one is always masking the other, making it impossible to use it (I would expect).
@robinhasse
Copy link
Contributor

Sorry for that. We'll soon have only one function in mrcommons to ensure a consistent split.
Solved by #50

@robinhasse robinhasse linked a pull request Dec 6, 2024 that will close this issue
Unit shift: USD2005 -> USD2017 #50
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinhasse robinhasse

@ricardarosemann ricardarosemann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit shift: USD2005 -> USD2017 robinhasse/mredgebuildings
2 participants
@robinhasse @ricardarosemann