Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pcc and pco from mrremind #351

Open
7 of 9 tasks
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 25, 2023 · 3 comments
Open
7 of 9 tasks

remove pcc and pco from mrremind #351

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 25, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Jan 25, 2023

@fbenke-pik
Copy link
Contributor

calcCCScapacity has been updated using IEA_CCUS in the meantime. I assume, this solves this TODO with respect to calcCCScapacity? If so, we could also delete the subtype '08-09-2017' from readGlobalCCSinstitute, as it is no used in mrremind anymore. Any objections?

@fbenke-pik
Copy link
Contributor

regarding calcCCSbounds: not sure how to move pcc and pco from that source, this is basically an expert guess by @strefler, consisting of one value per iso-country, either 0 or 1, presumably in TW. So for now, assuming that nothing needs to be changed in this function.

@fbenke-pik
Copy link
Contributor

fbenke-pik commented Sep 3, 2024

I merged a PR removing pcc and pco from most of the functions mentioned above -> #535

Would need someone to comment on calcCCSbounds and calcCCScapacity still so we can close this issue or add more adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants