Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for unitless variables in IIASA Projects #407

Open
fbenke-pik opened this issue Nov 20, 2024 · 1 comment
Open

Improve support for unitless variables in IIASA Projects #407

fbenke-pik opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@fbenke-pik
Copy link
Collaborator

fbenke-pik commented Nov 20, 2024

In IIASA Projects like ScenarioMIP there are unitless variables, for example Terrestrial Biodiversity|Shannon Crop Diversity Index. Internal checks like checkVarNames require a unit for variable and piam_variable.

The current solution (#405) is resolving the conflict by adding project-specific exceptions to checkVarNames, but this might not be elegant once more projects require such exceptions.

Alternative solutions could be

  • convince IIASA to not accept empty units and introduce unitless for this purpose (Laurin will ask)
  • internally use a reserved word (e.g. unitless in our mappings) to satisfy our internal checks, but adjust generateIIASASubmission to not write a unit into the submission to also satisfy IIASA's unit checks
  • just stick with the current solution.
@fbenke-pik fbenke-pik added enhancement New feature or request question Further information is requested labels Nov 20, 2024
@fbenke-pik
Copy link
Collaborator Author

@orichters Let us know if you have encountered this problem before and if not, which solution you'd prefer.

@fbenke-pik fbenke-pik changed the title Consider better support for unitless variables in IIASA Projects Improve support for unitless variables in IIASA Projects Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants