Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dimension types? #26

Open
JakobBD opened this issue Aug 23, 2024 · 1 comment
Open

Get dimension types? #26

JakobBD opened this issue Aug 23, 2024 · 1 comment
Labels

Comments

@JakobBD
Copy link
Collaborator

JakobBD commented Aug 23, 2024

These already exist in ODYM.

Types could be "time", "region", "element", and "other".

It would ease the assertion in the DSM that the first dimension is a time dimension, while still allowing several dimensions of the same kind (like years and historic years), and allowing different names for the dimensions (time, years, months, ...)

Not sure yet if it's worth the overhead...

@SallyDa
Copy link
Collaborator

SallyDa commented Aug 23, 2024

I just added a check and raise error, for the first dimension being time in the DSM (on my dsm branch), but yes, it's not particularly clean. I also thought about using datetime objects for the time dimension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants