Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark submissions to elastic have wrong build type #1376

Open
msimberg opened this issue Dec 18, 2024 · 4 comments
Open

Benchmark submissions to elastic have wrong build type #1376

msimberg opened this issue Dec 18, 2024 · 4 comments
Labels
category: CI Continuous Integration effort: 3 A few days of work. effort: 4 A few weeks of work. priority: medium This should be done sooner or later. type: bug

Comments

@msimberg
Copy link
Contributor

@msimberg msimberg added effort: 3 A few days of work. effort: 4 A few weeks of work. priority: medium This should be done sooner or later. type: bug category: CI Continuous Integration labels Dec 18, 2024
@aurianer aurianer assigned aurianer and unassigned aurianer Dec 19, 2024
@aurianer
Copy link
Contributor

aurianer commented Dec 19, 2024

The variables including the BUILD_TYPE are not printed in the logs of the build (see here), I think it would be nice to have them printed. What do you think?

@msimberg
Copy link
Contributor Author

The variables including the BUILD_TYPE are not printed in the logs of the build (see here), I think it would be nice to have them printed. What do you think?

Yep, that certainly wouldn't hurt.

Note that for this particular issue I think the build type is correct at the build step, but my guess is that the propagation of environment variables through the dotenv files isn't working as expected in the test step (likely due to the matrix setup?). So at the very least we'd also want to print relevant environment variables in the test step as well, not only the build step(s).

@aurianer
Copy link
Contributor

Yes I was thinking the same but still wanted to do a sanity check

@msimberg
Copy link
Contributor Author

Yes I was thinking the same but still wanted to do a sanity check

Yeah, for sure. Whatever the actual cause of this issue is, being more verbose is 100% welcome in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI Continuous Integration effort: 3 A few days of work. effort: 4 A few weeks of work. priority: medium This should be done sooner or later. type: bug
Projects
Status: Backlog
Development

No branches or pull requests

2 participants